Skip to content

Increase the speed of PageElement.isDisplayed #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougnoel opened this issue Mar 7, 2021 · 0 comments · Fixed by #250
Closed

Increase the speed of PageElement.isDisplayed #186

dougnoel opened this issue Mar 7, 2021 · 0 comments · Fixed by #250
Labels
enhancement New feature or request TODO Issue tied to a TODO: comment in the code
Milestone

Comments

@dougnoel
Copy link
Owner

dougnoel commented Mar 7, 2021

Likely the same fix as for #185

PageElement.isDisplayed() is called by VerificationSteps.verifyElementIsHidden() it takes a timeout Parameter in seconds, set to 1 second if we expect it to fail, and 10 if we expect it to pass.

The isDisplayed() functionality uses a FluentWait that only checks every 500 milliseconds. It also times out after 5 failed exceptions are thrown. It should be checking every 10 milliseconds. If a zero is passed, it should check once then fail immediately. Otherwise, it should continue checking until the time it out.

verifyElementIsHidden should also pull the timeout from the ConfigurationManager.

@dougnoel dougnoel added enhancement New feature or request TODO Issue tied to a TODO: comment in the code labels Mar 7, 2021
@dougnoel dougnoel added this to the 2.1.0 milestone Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TODO Issue tied to a TODO: comment in the code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant