Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo SDK workaround for props import issue after updating to Preview 4 SDK #4526

Closed
ryalanms opened this issue May 18, 2021 · 0 comments
Closed

Undo SDK workaround for props import issue after updating to Preview 4 SDK #4526

ryalanms opened this issue May 18, 2021 · 0 comments
Assignees
@ryalanms
Labels
Bug Product bug (most likely)
Milestone
6.0.0

Comments

@ryalanms
Copy link
Member

Remove WPF's workaround for SDK issue: dotnet/sdk#16725.

https://github.com/dotnet/wpf/blob/main/eng/WpfArcadeSdk/tools/Wpf.Cpp.props#L12

    <!-- This should be removed when .NET 6 Preview 4 becomes available. P4 contains the SDK fix. --> 
    <!--    https://github.com/dotnet/core/issues/6066 -->
    <!--    https://github.com/dotnet/sdk/issues/16725 -->
    <ILLinkTasksAssembly>DummyPropertyValueForILLinkTasksAssembly</ILLinkTasksAssembly>
@ryalanms ryalanms self-assigned this May 24, 2021
@ryalanms ryalanms added this to the 6.0.0 milestone May 24, 2021
@ryalanms ryalanms mentioned this issue Jun 7, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryalanms ryalanms

Labels
Bug Product bug (most likely)
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@ryalanms