Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental Build in Visual Studio 2019 and WPF with .NET Core 3.0 broken #1981

Closed
TFTomSun opened this issue Oct 1, 2019 · 3 comments
Closed
Assignees
Labels
Bug Product bug (most likely) Investigate Requires further investigation by the WPF team.
Milestone

Comments

@TFTomSun
Copy link

TFTomSun commented Oct 1, 2019

  • Create a library with the following project file:
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">

  <PropertyGroup>
    <TargetFramework>netcoreapp3.0</TargetFramework>
    <UseWPF>true</UseWPF>
  </PropertyGroup>

</Project>

  • To keep it simple, leave the library empty

-> The delta build in Visual Studio is broken. Normally Visual Studio would not build the project on the second build, if no changes have been performed. But WPF libraries are always build again, which also causes dependent projects to be rebuild. WPF apps don't have that issue.

Unfortunately the diagnostic build output does not tell any reason why the project is build again.

@weltkante
Copy link

weltkante commented Oct 1, 2019

#460 looks related but the scenario differs in the details - could be the same underlying root cause though. Unfortunately #460 has been postponed to 'Future' (i.e. not planned for 3.1 or 5.0) which sounds weird considering its a regression in the build experience? Or maybe in the discussion of #460 it didn't become clear that it was a regression?

@grubioe grubioe changed the title Delta Build in Visual Studio 2019 and WPF with .NET Core 3.0 broken Incremental Build in Visual Studio 2019 and WPF with .NET Core 3.0 broken Oct 1, 2019
@grubioe grubioe modified the milestone: 3.1 Oct 1, 2019
@arpitmathur arpitmathur added this to the Future milestone Nov 21, 2019
@arpitmathur arpitmathur added the Bug Product bug (most likely) label Nov 21, 2019
@ryalanms ryalanms self-assigned this Jan 12, 2021
@ryalanms ryalanms added the Investigate Requires further investigation by the WPF team. label Jan 12, 2021
@ryalanms ryalanms modified the milestones: Future, .NET 5.0 Servicing Jan 12, 2021
@ryalanms
Copy link
Member

This is likely fixed by @MichaeIDietrich: #4053.

@ryalanms
Copy link
Member

ryalanms commented Feb 3, 2021

Fixed by @MichaeIDietrich: #4053. Please reactivate if you see any new incremental build issues.

@ryalanms ryalanms closed this as completed Feb 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Product bug (most likely) Investigate Requires further investigation by the WPF team.
Projects
None yet
Development

No branches or pull requests

5 participants