Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply EditorBrowsableAttribute to contract items which aren't functioning #3898

Closed
2 tasks done
mconnew opened this issue Sep 10, 2019 · 1 comment
Closed
2 tasks done

Apply EditorBrowsableAttribute to contract items which aren't functioning #3898

mconnew opened this issue Sep 10, 2019 · 1 comment
Assignees
@mconnew
Labels
Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.
Milestone
3.1.x

Comments

@mconnew
Copy link
Member

mconnew commented Sep 10, 2019 •
edited by StephenBonikowsky
Loading

Some of the API's on our contract aren't usable. For example, SecurityTokenManager.CreateSecurityTokenAuthenticator has been added as it is an abstract method on an abstract class and without it, you can't derive SecurityTokenManager in a way which will work on .NET Framework on .NET Core. We also have many api's which accept a configuration name such as a constructor for CustomBinding.

By adding the EditorBrowsableAttrribute to these api's with the state EditorBrowsableState.Never we prevent these api's from being shown by intellisense when using our contract.
@StephenBonikowsky StephenBonikowsky added this to the 3.1 milestone Sep 23, 2019
@mconnew mconnew mentioned this issue Nov 1, 2019
Merged
@StephenBonikowsky StephenBonikowsky modified the milestones: 3.1, 3.1.1 Jan 6, 2020
@StephenBonikowsky StephenBonikowsky added the Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases. label Jan 6, 2020
@StephenBonikowsky StephenBonikowsky modified the milestones: 3.1.1, 3.1.x Jan 24, 2020
@StephenBonikowsky
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mconnew mconnew

Labels
Net Core 3.1 LTS Servicing Tasks planned for the WCF NET Core 3.1 Servicing releases.
Projects
None yet
Milestone
3.1.x
Development

No branches or pull requests
2 participants
@mconnew @StephenBonikowsky