Skip to content

Extremely slow to load solution in Aspire repo #8152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dibarbet opened this issue Apr 8, 2025 · 3 comments
Closed

Extremely slow to load solution in Aspire repo #8152

dibarbet opened this issue Apr 8, 2025 · 3 comments
Assignees
Labels
Bug Razor Urgent To be treated like a P0
Milestone

Comments

@dibarbet
Copy link
Member

dibarbet commented Apr 8, 2025

Starting some dogfooding on aspire and noticed that the solution load is incredibly slow. While progress is seemingly being made, it has taken over 5 minutes and is not done.

I've noticed that the Roslyn server is getting spammed by two different requests (many many thousands of requests)

2025-04-08 10:19:01.645 [info] [Debug - 10:19:01 AM] [workspace/buildOnlyDiagnosticIds] [LanguageServerHost] Starting request handler
2025-04-08 10:19:01.645 [info] [Debug - 10:19:01 AM] [workspace/buildOnlyDiagnosticIds] [LanguageServerHost] Request handler completed successfully.

And

2025-04-08 10:11:42.162 [info] [Debug - 10:11:42 AM] [razor/dynamicFileInfoChanged] [LanguageServerHost] Starting request handler

~20k requests for each.

Additionally, there are many workspace/diagnostic requests as well, likely triggered by workspace refresh notifications.

Sometimes the project loads, but the request spam makes it so no other features work.

Prerelease version 2.73.16

@dibarbet
Copy link
Member Author

dibarbet commented Apr 8, 2025

With the fix for the build only diagnostics requests, I'm still seeing thousands of razor/dynamicFileInfoChanged requests, appearing to overload the Roslyn server. 10 minutes after opening dotnet/aspire I'm still seeing 10s of requests per second (up to about ~8k requests total). Normal C# language features respond incredibly slowly as they get blocked in the queue by these ones.

@dibarbet dibarbet added the Razor label Apr 8, 2025
@dibarbet dibarbet assigned ryzngard and unassigned dibarbet Apr 8, 2025
@arunchndr arunchndr added the Urgent To be treated like a P0 label Apr 9, 2025
@dibarbet
Copy link
Member Author

dibarbet commented Apr 9, 2025

(Some additional details)

Appears to have started in this release - https://github.com/dotnet/vscode-csharp/releases/tag/v2.72.22

Before this release, Roslyn does get ~1k razor/dynamicFileInfoChanged requests, but then they stop soon after solution load completes and no changes are made.

After this release, I've gotten up to ~9k requests that never seem to stop even while no changes are being made.

@ryzngard
Copy link
Member

Fixed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Razor Urgent To be treated like a P0
Projects
None yet
Development

No branches or pull requests

3 participants