Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically reference shared frameworks from dependencies #10077

Closed
dsplaisted opened this issue Jan 28, 2019 · 0 comments · Fixed by #3221
Closed

Automatically reference shared frameworks from dependencies #10077

dsplaisted opened this issue Jan 28, 2019 · 0 comments · Fixed by #3221
Milestone

Comments

@dsplaisted
Copy link
Member

If a dependency of a project (either another project in the solution, or a NuGet package) depends on an optional shared framework, then the project with the dependency should also depend on that shared framework.

This depends on NuGet writing these dependencies to the assets file: NuGet/Home#7342. Once that is done we will raise them into framework references.

We will also need to download all targeting packs for the targeted framework in case we might need to depend on them via a transitive dependency (which we won't know about until after restore has happened).

NOTE: We would also like to have a property to disable transitive framework references (which would then disable the automatic download of packages you might not need).

dsplaisted referenced this issue in dsplaisted/sdk May 9, 2019
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 3.0.1xx milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants