Fixing SignedXml.CheckSignature for enveloped signature with #xpointer(/) Reference
#95404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsStarted poking at #95390
|
This was referenced Nov 29, 2023
m0sa
changed the title
#xpointer(/) Reference#xpointer(/) Reference
vcsjones
reviewed
Nov 29, 2023
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Outdated
Show resolved
Hide resolved
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Show resolved
Hide resolved
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Show resolved
Hide resolved
…rity/Cryptography/Xml/Reference.cs Co-authored-by: Kevin Jones <vcsjones@github.com>
…rity/Cryptography/Xml/Reference.cs Co-authored-by: Kevin Jones <vcsjones@github.com>
vcsjones
reviewed
Dec 8, 2023
src/libraries/System.Security.Cryptography.Xml/tests/SignedXmlTest.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 3, 2024
...libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Reference.cs
Show resolved
Hide resolved
bartonjs
added
the
needs-author-action
ghost
removed
the
needs-author-action
This was referenced Feb 15, 2024
bartonjs
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
I'm slightly displeased at how the null URI got included in this change sort of just-because (i.e. it wasn't part of the original problem description); but there's not really reason to break it apart at this point. (Except that the PR / final commit needs a better title.)
_uri values that are non-empty and don't start with # will now take a different path through the code; but it ends up having the same effect.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for #95390 and implements a fix.