Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RyuJIT/ARM32] Can't run corefx tests with COMPlus_AltJit #8725

Closed
hqueue opened this issue Aug 11, 2017 · 5 comments
Closed

[RyuJIT/ARM32] Can't run corefx tests with COMPlus_AltJit #8725

hqueue opened this issue Aug 11, 2017 · 5 comments
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Milestone

Comments

@hqueue
Copy link
Member

hqueue commented Aug 11, 2017

When running corefx tests with COMPlus_AltJit to test ryujit/arm32, test can't start as follows on Rpi3.

hqueue@rpi3:/corefx_tests/AnyOS.AnyCPU.Release/System.Buffers.Tests/netstandard$ COMPlus_AltJit=* /coreoverlay/corerun xunit.console.netcore.exe System.Buffers.Tests.dll  -xml testResults.xml -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests  -notrait category=failing
xUnit.net console test runner (32-bit .NET Core)
Copyright (C) 2014 Outercurve Foundation.

Discovering: System.Buffers.Tests
System.NullReferenceException: Object reference not set to an instance of an object.

Without COMPlus_AltJit, it works well.

hqueue@rpi3:/corefx_tests/AnyOS.AnyCPU.Release/System.Buffers.Tests/netstandard$ /coreoverlay/corerun xunit.console.netcore.exe System.Buffers.Tests.dll  -xml testResults.xml -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests  -notrait category=failing
xUnit.net console test runner (32-bit .NET Core)
Copyright (C) 2014 Outercurve Foundation.

Discovering: System.Buffers.Tests
Discovered:  System.Buffers.Tests
Starting:    System.Buffers.Tests
Finished:    System.Buffers.Tests

=== TEST EXECUTION SUMMARY ===
   System.Buffers.Tests  Total: 77, Errors: 0, Failed: 0, Skipped: 0, Time: 18.411s

Does any body know how to run corefx tests with COMPlus_AltJit option ?
Note: I've used corerun instead of dotnet which is supposed to be used for corefx tests as default.

@hqueue
Copy link
Member Author

hqueue commented Aug 11, 2017

/cc: @BruceForstall Please take a look. Is it possible to run corefx tests with AltJit ?

/cc: @dotnet/arm32-contrib

@BruceForstall
Copy link
Member

I haven't ever tried running corefx tests with altjit. Have you tried debugging to see where the failure is? I presume protojit.dll (or libprotojit.so?) exists in the same location as the regular clrjit?

A somewhat unsatisfying option is to (temporarily) change clrjit to be RyuJIT, by changing that build to not define LEGACY_BACKEND. You wouldn't get any NYI fallback if you do that.

@hqueue
Copy link
Member Author

hqueue commented Aug 11, 2017

Have you tried debugging to see where the failure is?

I tried to debug it with gdb but got no meaningful clue untiil now.

I presume protojit.dll (or libprotojit.so?) exists in the same location as the regular clrjit?

Yes. There is libprotojit.so and I have ran coreclr tests with same coreoverlay using altjit option

A somewhat unsatisfying option is to (temporarily) change clrjit to be RyuJIT, by changing that build to not define LEGACY_BACKEND. You wouldn't get any NYI fallback if you do that.

I also think about this option but as the last choice.

@hqueue
Copy link
Member Author

hqueue commented Aug 11, 2017

@BruceForstall Found a reason. It seems that recent regression in ryujit/arm32 caused the failure.

I'm going to close this after the regression is fixed.

@hqueue
Copy link
Member Author

hqueue commented Aug 16, 2017

Fixed by dotnet/coreclr#13364

@hqueue hqueue closed this as completed Aug 16, 2017
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm32 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug
Projects
None yet
Development

No branches or pull requests

3 participants