Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure illink packages flow to source build #80319

Closed
Tracked by #75278
tlakollo opened this issue Jan 6, 2023 · 3 comments
Closed
Tracked by #75278

Ensure illink packages flow to source build #80319

tlakollo opened this issue Jan 6, 2023 · 3 comments
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Milestone

Comments

@tlakollo
Copy link
Contributor

tlakollo commented Jan 6, 2023

Currently, runtime generates the Microsoft.NET.ILLink.Tasks.nupkg as part of the Default subset command, its still missing a CI leg that actually executes this command, but after that is done we need to ensure that all the previous references from dotnet/linker get changes to runtime. This includes changing the references to the source build inside SDK and installer.

Also, we need to add this same metadata into the Version.Details.xml in runtime for the dotnet/cecil repository

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jan 6, 2023
@tlakollo tlakollo added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jan 6, 2023
@ghost
Copy link

ghost commented Jan 6, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently, runtime generates the Microsoft.NET.ILLink.Tasks.nupkg as part of the Default subset command, its still missing a CI leg that actually executes this command, but after that is done we need to ensure that all the previous references from dotnet/linker get changes to runtime. This includes changing the references to the source build inside SDK and installer.

Also, we need to add this same metadata into the Version.Details.xml in runtime for the dotnet/cecil repository

Author: tlakollo
Assignees: -
Labels:

untriaged, area-Tools-ILLink

Milestone: -

@tlakollo tlakollo added this to the 8.0.0 milestone Jan 6, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jan 6, 2023
@tlakollo
Copy link
Contributor Author

tlakollo commented Feb 8, 2023

Closed via dotnet/installer#15389, dotnet/sdk#30256, #81756

@tlakollo tlakollo closed this as completed Feb 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers
Projects
None yet
Development

No branches or pull requests

1 participant