Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContainBlockStoreAddress on arm64 can remove handles #76552

Open
jakobbotsch opened this issue Oct 3, 2022 · 3 comments
Open

ContainBlockStoreAddress on arm64 can remove handles #76552

jakobbotsch opened this issue Oct 3, 2022 · 3 comments
Assignees
@kunalspathak
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Oct 3, 2022 •
edited by BruceForstall
Loading

The armarch version of Lowering::ContainBlockStoreAddress has tiny inlined version of TryCreateAddrMode that seems like it needs to be audited. In addition to the issue in #76532, it can also remove handles.

We should figure out if we can replace it with (a subset of) TryCreateAddrMode, and otherwise at least fix the handle issue.

category:correctness
theme:lower
skill-level:intermediate
cost:small
impact:small
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@jakobbotsch jakobbotsch added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 3, 2022
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Oct 3, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 3, 2022
@ghost
Copy link

ghost commented Oct 3, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The armarch version of Lowering::ContainBlockStoreAddress has tiny inlined version of TryCreateAddrMode that seems like it needs to be audited. In addition to the issue in #76532, it can also remove handles.

We should figure out if we can replace it with (a subset of) TryCreateAddrMode, and otherwise at least fix the handle issue.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch mentioned this issue Oct 3, 2022
Closed
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Oct 4, 2022
@TIHan TIHan modified the milestones: 8.0.0, Future Jun 9, 2023
@kunalspathak
Copy link
Member

@jakobbotsch - can you confirm if this is still relevant and if yes, share more details?

@kunalspathak kunalspathak assigned kunalspathak and unassigned TIHan Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kunalspathak kunalspathak

Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@TIHan @jakobbotsch @BruceForstall @kunalspathak @JulieLeeMSFT