Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembly.GetCallingAssembly should be marked with [RequiresDynamicCode]. #71290

Closed
teo-tsirpanis opened this issue Jun 25, 2022 · 6 comments
Closed

Assembly.GetCallingAssembly should be marked with [RequiresDynamicCode]. #71290

teo-tsirpanis opened this issue Jun 25, 2022 · 6 comments
Assignees
@LakshanF
Labels
area-System.Reflection linkable-framework Issues associated with delivering a linker friendly framework
Milestone
Future

Comments

@teo-tsirpanis
Copy link
Contributor

As indicated in #53825, Assembly.GetCallingAssembly is not supported in AOT environments. It should be applied the [RequiresDynamicCodeAttribute] to make this visible.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 25, 2022
@ghost
Copy link

ghost commented Jun 25, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

As indicated in #53825, Assembly.GetCallingAssembly is not supported in AOT environments. It should be applied the [RequiresDynamicCodeAttribute] to make this visible.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Reflection, untriaged
Milestone: -

@AaronRobinsonMSFT AaronRobinsonMSFT added the linkable-framework Issues associated with delivering a linker friendly framework label Jun 27, 2022
@ghost
Copy link

ghost commented Jun 27, 2022

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr
See info in area-owners.md if you want to be subscribed.

Issue Details

As indicated in #53825, Assembly.GetCallingAssembly is not supported in AOT environments. It should be applied the [RequiresDynamicCodeAttribute] to make this visible.

Author: teo-tsirpanis
Assignees: -
Labels:

area-System.Reflection, untriaged, linkable-framework
Milestone: -

@buyaa-n buyaa-n removed the untriaged New issue has not been triaged by the area owner label Jul 11, 2022
@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 11, 2022

@LakshanF set 8.0 milestone as I am not sure when you are planning to work on this, feel free to change as needed

@buyaa-n buyaa-n added this to the 8.0.0 milestone Jul 11, 2022
@teo-tsirpanis
Copy link
Contributor Author

So it's approved I guess. I am working on it.

@teo-tsirpanis teo-tsirpanis modified the milestones: 8.0.0, 7.0.0 Jul 11, 2022
@teo-tsirpanis teo-tsirpanis modified the milestones: 7.0.0, 8.0.0 Jul 11, 2022
@teo-tsirpanis teo-tsirpanis mentioned this issue Jul 11, 2022
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 11, 2022
@teo-tsirpanis teo-tsirpanis changed the title Mark Assembly.GetCallingAssembly with [RequiresDynamicCode]. Assembly.GetCallingAssembly should be marked with [RequiresDynamicCode]. Jul 11, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 20, 2022
@buyaa-n
Copy link
Contributor

buyaa-n commented Jul 20, 2022

As per discussion in #71973 (comment) we want to obsolete this API instead, after dotnet/csharplang#4984 implemented

@buyaa-n buyaa-n modified the milestones: 8.0.0, Future Jul 20, 2022
@teo-tsirpanis teo-tsirpanis closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LakshanF LakshanF

Labels
area-System.Reflection linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Mark Assembly.GetCallingAssembly with [RequiresDynamicCode]. teo-tsirpanis/dotnet-runtime
4 participants
@LakshanF @teo-tsirpanis @AaronRobinsonMSFT @buyaa-n