Assertion failed 'vnStore->VNExcIsSubset(nodeExcSet.GetLiberal(), operandsExcSet.GetLiberal())' during 'Do value numbering'

[kunalspathak]

// Found by Antigen
using System;
using System.Collections.Generic;
using System.Runtime.CompilerServices;
public class TestClass
{
    public struct S1
    {
    }
    static S1 s_s1_32 = new S1();
    public S1 LeafMethod15()
    {
        unchecked
        {
            return s_s1_32;
        }
    }
    public void Method0()
    {
        unchecked
        {
            LeafMethod15();
            return;
        }
    }
    public static void Main(string[] args)
    {
        new TestClass().Method0();
    }
}

/*
Environment:

set COMPlus_TieredCompilation=0
set COMPlus_JitAggressiveInlining=1

Assert failure(PID 71508 [0x00011754], Thread: 29652 [0x73d4]): Assertion failed 'vnStore->VNExcIsSubset(nodeExcSet.GetLiberal(), operandsExcSet.GetLiberal())' in 'TestClass:Method0():this' during 'Do value numbering' (IL size 8)
    File: D:\git\dotnet-runtime\src\coreclr\jit\valuenum.cpp Line: 11074
    Image: d:\git\dotnet-runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\CoreRun.exe
*/

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

// Found by Antigen
using System;
using System.Collections.Generic;
using System.Runtime.CompilerServices;
public class TestClass
{
    public struct S1
    {
    }
    static S1 s_s1_32 = new S1();
    public S1 LeafMethod15()
    {
        unchecked
        {
            return s_s1_32;
        }
    }
    public void Method0()
    {
        unchecked
        {
            LeafMethod15();
            return;
        }
    }
    public static void Main(string[] args)
    {
        new TestClass().Method0();
    }
}

/*
Environment:

set COMPlus_TieredCompilation=0
set COMPlus_JitAggressiveInlining=1

Assert failure(PID 71508 [0x00011754], Thread: 29652 [0x73d4]): Assertion failed 'vnStore->VNExcIsSubset(nodeExcSet.GetLiberal(), operandsExcSet.GetLiberal())' in 'TestClass:Method0():this' during 'Do value numbering' (IL size 8)
    File: D:\git\dotnet-runtime\src\coreclr\jit\valuenum.cpp Line: 11074
    Image: d:\git\dotnet-runtime\artifacts\tests\coreclr\windows.x64.Checked\tests\Core_Root\CoreRun.exe
*/

Author:	kunalspathak
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[kunalspathak]

@dotnet/jit-contrib , @jakobbotsch

[SingleAccretion]

I will take a look, should be a straightforward fix.