Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex source generator should include capture group name in comment #62715

Closed
stephentoub opened this issue Dec 13, 2021 · 2 comments · Fixed by #63255
Closed

Regex source generator should include capture group name in comment #62715

stephentoub opened this issue Dec 13, 2021 · 2 comments · Fixed by #63255
Labels
area-System.Text.RegularExpressions good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Milestone
7.0.0

Comments

@stephentoub
Copy link
Member

Given an expression like:

"^(?<LINE>[0-9]*)-(?<ENDLINE>[0-9]*)$"

the regex source generator will output comments for the groups like:

// 1st capturing group

We should include the name if one exists, e.g.

// 1st capturing group ("LINE")
@stephentoub stephentoub added this to the 7.0.0 milestone Dec 13, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Dec 13, 2021
@ghost
Copy link

ghost commented Dec 13, 2021

Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions
See info in area-owners.md if you want to be subscribed.

Issue Details

Given an expression like:

"^(?<LINE>[0-9]*)-(?<ENDLINE>[0-9]*)$"

the regex source generator will output comments for the groups like:

// 1st capturing group

We should include the name if one exists, e.g.

// 1st capturing group ("LINE")
Author: stephentoub
Assignees: -
Labels:

area-System.Text.RegularExpressions
Milestone: 7.0.0

@danmoseley danmoseley added good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors labels Dec 13, 2021
@joperezr joperezr mentioned this issue Dec 14, 2021
Closed
48 tasks
@pedrobsaila pedrobsaila mentioned this issue Jan 1, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 1, 2022
@pedrobsaila
Copy link
Contributor

pedrobsaila commented Jan 1, 2022 •
edited
Loading

I made a PR #63255 for this issue

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 11, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Text.RegularExpressions good first issue Issue should be easy to implement, good for first-time contributors help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

add capture group name in comment pedrobsaila/runtime
4 participants
@stephentoub @danmoseley @jeffschwMSFT @pedrobsaila