Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Managed Threadpool Diagnostics #45384

Closed
1 of 5 tasks
Tracked by #5929
tommcdon opened this issue Nov 30, 2020 · 2 comments · Fixed by #47829
Closed
1 of 5 tasks
Tracked by #5929

Support Managed Threadpool Diagnostics #45384

tommcdon opened this issue Nov 30, 2020 · 2 comments · Fixed by #47829
Assignees
@sywhang
Labels
area-Diagnostics-coreclr Bottom Up Work Not part of a theme, epic, or user story User Story A single user-facing feature. Can be grouped under an epic.
Milestone
6.0.0

Comments

@tommcdon
Copy link
Member

tommcdon commented Nov 30, 2020 •
edited by sywhang
Loading

The goal is to maintain parity with existing diagnostics for the native thread pool. Currently the concrete work for this item is:

  • Make NativeRuntimeEventSource.cs as a general way of sending runtime events from managed side, as opposed to what it is now
  • Make sure the events being fired from the managed ThreadPool is being fired correctly.
  • Fix EventListener deadlock that can occur as part of enabling managed threadpool events through EventListener
  • Make sure EventListeners can subscribe to managed threadpool events
  • Test LTTng events can still get fired from managed threadpool under the Microsoft-Windows-DotNETRuntime provider
@tommcdon tommcdon added this to the 6.0.0 milestone Nov 30, 2020
@ghost
Copy link

ghost commented Nov 30, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Make NativeRuntimeEventSource.cs as a general way of sending runtime events from managed side, as opposed to what it is now

Author: tommcdon
Assignees: -
Labels:

area-Diagnostics-coreclr
Milestone: 6.0.0

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 30, 2020
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Nov 30, 2020
@sywhang
Copy link
Contributor

sywhang commented Dec 7, 2020 •
edited
Loading

#45666 fixed an issue where the managed threadpool was firing several verbose threadpool events whenever any runtime event is enabled.

@tommcdon tommcdon added the User Story A single user-facing feature. Can be grouped under an epic. label Dec 9, 2020
@tommcdon tommcdon mentioned this issue Dec 10, 2020
Closed
@tommcdon tommcdon added the Bottom Up Work Not part of a theme, epic, or user story label Dec 10, 2020
@sywhang sywhang self-assigned this Jan 20, 2021
@sywhang sywhang mentioned this issue Feb 4, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 4, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 11, 2021
@shirhatti shirhatti mentioned this issue Mar 11, 2021
Closed
18 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sywhang sywhang

Labels
area-Diagnostics-coreclr Bottom Up Work Not part of a theme, epic, or user story User Story A single user-facing feature. Can be grouped under an epic.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Enable Portable ThreadPool events to be written using NativeRuntimeEventSource sywhang/runtime
3 participants
@tommcdon @sywhang @Dotnet-GitSync-Bot