Nullable annotation mismatch in System.Text.Json.JsonException

[huoyaoyuan]

ref

runtime/src/libraries/System.Text.Json/ref/System.Text.Json.cs

Lines 145 to 146 in d81b066

	public JsonException(string? message, string path, long? lineNumber, long? bytePositionInLine) { }
	public JsonException(string? message, string path, long? lineNumber, long? bytePositionInLine, System.Exception? innerException) { }

impl

runtime/src/libraries/System.Text.Json/src/System/Text/Json/JsonException.cs

Lines 29 to 47 in d81b066

	public JsonException(string? message, string path, long? lineNumber, long? bytePositionInLine, Exception? innerException) : base(message, innerException)
	{
	_message = message;
	LineNumber = lineNumber;
	BytePositionInLine = bytePositionInLine;
	Path = path;
	}
	/// <summary>
	/// Creates a new exception object to relay error information to the user.
	/// </summary>
	/// <param name="message">The context specific error message.</param>
	/// <param name="path">The path where the invalid JSON was encountered.</param>
	/// <param name="lineNumber">The line number at which the invalid JSON was encountered (starting at 0) when deserializing.</param>
	/// <param name="bytePositionInLine">The byte count within the current line where the invalid JSON was encountered (starting at 0).</param>
	/// <remarks>
	/// Note that the <paramref name="bytePositionInLine"/> counts the number of bytes (i.e. UTF-8 code units) and not characters or scalars.
	/// </remarks>
	public JsonException(string? message, string? path, long? lineNumber, long? bytePositionInLine) : base(message)

proposed

Annotate all path to nullable, since the Path property is decided to be nullable.

backport priority

Low. The update will be relaxing, and it should be uncommon for user to call constructor of library specified exception.

[jozkee]

This will be fixed in #41731; I will mark this issue as 5.0 since that PR is being ported to 5.0 in #41845, although, If aforementioned PR is rejected, I don't think this issue on its own would meet the bar.

[huoyaoyuan]

The PR title is misleading so I missed it. Thanks.

[layomia]

Closing as the fix was merged in #41845. cc @jozkee