Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventArgs type not Serializable #24461

Closed
AndyGerlicher opened this issue Dec 14, 2017 · 6 comments
Closed

EventArgs type not Serializable #24461

AndyGerlicher opened this issue Dec 14, 2017 · 6 comments
Labels
area-System.Runtime enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@AndyGerlicher
Copy link

MSBuild uses EventArgs base class to derive all build events and messages (see BuildEventArgs).

As part of our effort to migrate to netstandard2.0, we need this type to be marked Serializable in order to maintain compatibility between full framework and Core versions. Ideally this needs to be included in 2.0 servicing in the VS15.6 timeframe.

@danmosemsft

@karelz
Copy link
Member

karelz commented Dec 15, 2017

cc @ViktorHofer

@danmoseley
Copy link
Member

We should just do this. It's an empty base type. They are not asking for any derived types.

@ViktorHofer
Copy link
Member

PRs are open for coreclr (src), corefx (tests) and docs. This issue should be closed after the PR into the servicing branch is merged.

@jkotas
Copy link
Member

jkotas commented Dec 15, 2017

@AndyGerlicher Where is msbuild going to use binary serialization for this in .NET Core?

@AndyGerlicher
Copy link
Author

We use binary serialization for many things, in particular cache files and IPC for multi-proc builds. The type I linked (BuildEventArgs) is the base class for all our build messages/events which derives from BuildEvent (and is not ISerializable). And customers can (and do) create custom types that derive from our build event types.

@danmoseley
Copy link
Member

We allow serialization of EventArgs itself. No further changes planned.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.x milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

6 participants