Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: System.Tests.GCTests.GetAllocatedBytesForCurrentThread(size: 1000) #13502

Closed
AriNuer opened this issue Sep 30, 2019 · 5 comments
Closed
Labels
arch-x64 area-GC-coreclr os-linux Linux OS (any supported distro)
Milestone

Comments

@AriNuer
Copy link

AriNuer commented Sep 30, 2019

Job:
coreclr-corefx-jitstress:20190928.1

Details:
https://helix.dot.net/api/2019-06-17/jobs/a654ba18-0756-46fc-ba38-95d7942d8dae/workitems/System.Runtime.Tests/console

OS & Arch:
Linux x64

Mode:
export COMPlus_TieredCompilation=0
export COMPlus_DbgEnableMiniDump=1
export COMPlus_DbgMiniDumpName=$HELIX_DUMP_FOLDER/coredump.%d.dmp
export COMPlus_ReadyToRun=0
export COMPlus_ZapDisable=1

Note:
This failure not repro on our Linux x64 machine.

Log:

~/work/a654ba18-0756-46fc-ba38-95d7942d8dae/Work/3acc4c7c-94e3-454c-9a79-3951789a7c94/Exec ~/work/a654ba18-0756-46fc-ba38-95d7942d8dae/Work/3acc4c7c-94e3-454c-9a79-3951789a7c94/Exec
  Discovering: System.Runtime.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Runtime.Tests (found 5369 of 5417 test cases)
  Starting:    System.Runtime.Tests (parallel test collections = on, max threads = 2)
    System.Tests.GCTests.GetAllocatedBytesForCurrentThread(size: 1000) [FAIL]
      Allocated too much: start: 962032 end: 968264 size: 1000
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/System.Runtime/tests/System/GCTests.netcoreapp.cs(27,0): at System.Tests.GCTests.GetAllocatedBytesForCurrentThread(Int32 size)
    System.Tests.DateTimeOffsetTests.ToLocalTime_MaxValue [SKIP]
      Condition(s) not met: "IsMaxValuePositiveLocalOffset"
    System.Tests.DateTimeOffsetTests.ToLocalTime_MinValue [SKIP]
      Condition(s) not met: "IsMinValueNegativeLocalOffset"
    System.Tests.DateTimeOffsetTests.ToLocalTime_Ambiguous [SKIP]
      Condition(s) not met: "IsPacificTime"
    System.Tests.ArgIteratorTests.ArgIterator_GetNextArgType [SKIP]
      Condition(s) not met: "IsArgIteratorSupported"
    System.Tests.ArgIteratorTests.ArgIterator_GetRemainingCount_GetNextArg [SKIP]
      Condition(s) not met: "IsArgIteratorSupported"
  Finished:    System.Runtime.Tests
=== TEST EXECUTION SUMMARY ===
   System.Runtime.Tests  Total: 34396, Errors: 0, Failed: 1, Skipped: 5, Time: 352.362s
~/work/a654ba18-0756-46fc-ba38-95d7942d8dae/Work/3acc4c7c-94e3-454c-9a79-3951789a7c94/Exec
----- end Sun Sep 29 07:14:11 UTC 2019 ----- exit code 1 ----------------------------------------------------------
@BruceForstall
Copy link
Member

@ericstj @stephentoub @Maoni0 Random GC test failure? Is the test robust?

@Maoni0
Copy link
Member

Maoni0 commented Oct 1, 2019

@VSadov could you please take a look? this test should be robust.

@VSadov
Copy link
Member

VSadov commented Oct 1, 2019

will take a look

@VSadov VSadov self-assigned this Oct 1, 2019
@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@mangod9
Copy link
Member

mangod9 commented Jul 29, 2020

This havent reproed in a while.

@mangod9 mangod9 closed this as completed Jul 29, 2020
@VSadov
Copy link
Member

VSadov commented Aug 6, 2020

I think it was a per-thread vs. per-heap attribution problem. We could use different contexts depending on how allocation was made.
It was fixed in #33402 . It is always per-thread context now.

@VSadov VSadov removed their assignment Aug 6, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-GC-coreclr os-linux Linux OS (any supported distro)
Projects
None yet
Development

No branches or pull requests

6 participants