Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Linux/x64: 8 Regressions on 5/4/2024 5:29:12 AM #101989

Closed
performanceautofiler bot opened this issue May 7, 2024 · 5 comments
Closed

[Perf] Linux/x64: 8 Regressions on 5/4/2024 5:29:12 AM #101989

performanceautofiler bot opened this issue May 7, 2024 · 5 comments
Assignees
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented May 7, 2024

Run Information

Name Value
Architecture x64
OS ubuntu 22.04
Queue TigerUbuntu
Baseline 7ac5ef959579da0202e6ad618924dfc8fe129e89
Compare deb7c1707c00dd14bd9cd179c976ccfc1e70544d
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Memory.Span<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
1.72 ns 3.22 ns 1.88 0.25 False
0.93 ns 3.29 ns 3.53 0.20 False
1.14 ns 2.31 ns 2.02 0.14 False

graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Memory.Span&lt;Int32&gt;*'

System.Memory.Span<Int32>.StartsWith(Size: 33)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Int32>.SequenceEqual(Size: 4)

ETL Files

Histogram

JIT Disasms

System.Memory.Span<Int32>.StartsWith(Size: 4)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added arch-x64 os-linux Linux OS (any supported distro) runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels May 7, 2024
@DrewScoggins DrewScoggins removed the untriaged New issue has not been triaged by the area owner label May 7, 2024
@DrewScoggins DrewScoggins transferred this issue from dotnet/perf-autofiling-issues May 7, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 7, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label May 7, 2024
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels May 7, 2024
@DrewScoggins
Copy link
Member

Looks like #101834

@DrewScoggins
Copy link
Member

Improvements: dotnet/perf-autofiling-issues#33897

@AndyAyersMS AndyAyersMS removed the untriaged New issue has not been triaged by the area owner label May 8, 2024
@AndyAyersMS AndyAyersMS self-assigned this May 8, 2024
@AndyAyersMS AndyAyersMS added this to the 9.0.0 milestone May 8, 2024
@AndyAyersMS
Copy link
Member

Will revisit once we enable the new layout. Also curious to see the ARM64 results.

@AndyAyersMS AndyAyersMS added the Priority:2 Work that is important, but not critical for the release label May 8, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 9, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@vcsjones vcsjones removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 9, 2024
@AndyAyersMS
Copy link
Member

newplot - 2024-07-02T081544 572

These have all since improved, though it's not clear which commit(s) are responsible. Implicated range is 1be664e...29cb8a6

@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-x64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI os-linux Linux OS (any supported distro) Priority:2 Work that is important, but not critical for the release runtime-coreclr specific to the CoreCLR runtime tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

4 participants