Rename session randomly dismisses itself

[Peter-Juhasz]

Version Used: VS 17.11.0 P3

The issue first appeared either in this or the most recent previous preview release.

Steps to Reproduce:
Start a rename session and start typing new name.

It happens randomly, sometimes multiple times in a row, sometimes rarely.

See the second try:

Rogzites.2024-07-11.093008.mp4

(I have GitHub Copilot enabled as well, perhaps it is related to the newly introduced rename suggestions?)

Diagnostic Id:
N/A

Expected Behavior:
The rename session stays active while I type the new name and commit it.

Actual Behavior:
The rename session dismisses itself after typing the first character (or by itself?, I'm not sure what is the trigger).

[CyrusNajmabadi]

I'm also reproing this. Was doing a bunch of renames yesterday and about one in five would just randomly dismiss.

[Cosifne]

I merged a potential fix to this problem, so I am going to close this issue.
If anyone see this repro feel free to open it.

[grallbring]

Still happens to me using version 17.12.3:
https://github.com/user-attachments/assets/d9a07178-60fe-4abc-a73a-efcf0ef504cc

The rename dialog just randomly disappears when starting to type.

[Peter-Juhasz]

@grallbring The workaround that worked for me was to disable either in the Rename window or under GitHub > Copilot > Enable rename suggestions.

Although I have not enabled it yet since then and I'm on 17.13 P2, I have never encountered this issue since then again.

[CyrusNajmabadi]

@AmadeusW @gundermanc ^

[SirViver]

I also still have this issue on 17.12.3 and changing GitHub Copilot rename suggestions doesn't influence the problem for me. I think it has more to do with source generators (erroneously?) constantly re-running in the background (in my case the MVVM Community Toolkit ones), which constantly modifies/invalidates the Roslyn model, resulting in the rename to auto-dismiss.

If you try to do a classic rename by just renaming the thing and then invoking the Rename action you get following error:

Rename operation could not complete due to external change to workspace

Also VS seems to massively memory leak at this point, for example right now growing to 15GB memory usage, but I'm 100% sure its related.

[CyrusNajmabadi]

@SirViver please file a vs issue from within vs. It will collect perf traces and memory dumps to let us see what is going on.

[SirViver]

I've now logged an issue from within VS, including a whole bunch of dumps/extra traces, plus a video recording showing the behavior:

https://developercommunity.visualstudio.com/t/Rename-dialog-closes-itself-shortly-afte/10827608