Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorConfig GUI editor doesn't work for anything else than files named .editorconfig and in specific locations #70326

Open
Piedone opened this issue Oct 10, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@Piedone
Copy link
Member

Piedone commented Oct 10, 2023

Version Used: 4.7.0-3.23416.8 (43b0b05) I'm trying this in Visual Studio v17.7.4.

Steps to Reproduce:

  1. Open the Lombiq's Open-Source Orchard Core Extensions solution (you have to clone it with submodules, i.e. the git --recurse-submodules switch).
  2. Add the .editorconfig file that's generated in the root of the folder structure to the solution (like a solution-level item).
  3. Open it. Observe that the EditorConfig GUI editor is correctly loaded.
  4. Move the .editorconfig file to e.g. the tools folder, also add it to the solution, and open it. Observe that the EditorConfig GUI editor is NOT loaded.
  5. Repeat the previous but move the .editorconfig file to anywhere in the src folder. Observe that the EditorConfig GUI editor is correctly loaded.
  6. Open the .editorconfig file under the Lombiq.Analyzers project. Observe that the EditorConfig GUI editor is NOT loaded.
  7. Repeat the file-adding process with a .globalconfig file (any file should do the trick, but you can try the file I'm attaching below). Observe that the EditorConfig GUI editor is NOT loaded.

globalconfig.txt

Seems like almost, but not entirely, the same issue: #53845 But this is not fixed, as indicated by comments by others under that issue too.

Also related: #53120

Diagnostic Id: This doesn't seem like an analyzer bug.

Expected Behavior:

  • The EditorConfig UI is loaded when opening .editorconfig files regardless of where the file is on the file system.
  • The EditorConfig UI is loaded for .globalconfig files, both named just .globalconfig and Anything.globalconfig. This is necessary if you add analyzer rules to a global AnalyzerConfig, i.e. .globalconfig file, as instructed by the official docs instead of .editorconfig.

Actual Behavior:

  • The EditorConfig UI is only loaded when the .editorconfig file is put into the root folder, or within the src folder (perhaps because that's where the solution's startup project is).
  • The EditorConfig UI is NOT loaded for any .globalconfig file.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Oct 10, 2023
@jasonmalinowski jasonmalinowski removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 10, 2023
@beccamc beccamc assigned akhera99 and unassigned beccamc Dec 20, 2023
@arunchndr arunchndr added this to the Backlog milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants