Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete statement command doesn't work inside typeof #52137

Closed
Youssef1313 opened this issue Mar 25, 2021 · 4 comments · Fixed by #52364
Closed

Complete statement command doesn't work inside typeof #52137

Youssef1313 opened this issue Mar 25, 2021 · 4 comments · Fixed by #52364
Assignees
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone

Comments

@Youssef1313
Copy link
Member

completecommand

@bernd5
Copy link
Contributor

bernd5 commented Mar 25, 2021

Can you provide a reproducible sample with detailed error information?

@Youssef1313
Copy link
Member Author

It's not really an "error", but just a feature doesn't work in the case of typeof. The GIF in the issue shows when the feature works with a function, and when it doesn't work with typeof. It also seems to be expected based on the feature's code:

if (currentNode.IsKind(
SyntaxKind.ArgumentList,
SyntaxKind.ArrayRankSpecifier,
SyntaxKind.BracketedArgumentList,
SyntaxKind.ParenthesizedExpression,
SyntaxKind.ParameterList,
SyntaxKind.DefaultExpression,
SyntaxKind.CheckedExpression,
SyntaxKind.UncheckedExpression))

@Youssef1313
Copy link
Member Author

@jinujoseph The bot didn't put either an "untriaged" label nor an "Area-*" (IDE) label.

@jinujoseph
Copy link
Contributor

thanks for pointing it out @Youssef1313.
@jaredpar for info on bot missing out the label

@jinujoseph jinujoseph added the 4 - In Review A fix for the issue is submitted for review. label Apr 2, 2021
@sharwell sharwell modified the milestones: 16.10, Next Apr 2, 2021
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Apr 2, 2021
@dibarbet dibarbet modified the milestones: Next, 16.10.P3 Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants