Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnalysisLevel MSBuild property #3823

Closed
jmarolf opened this issue Jul 6, 2020 · 2 comments · Fixed by dotnet/sdk#12422
Closed

Add AnalysisLevel MSBuild property #3823

jmarolf opened this issue Jul 6, 2020 · 2 comments · Fixed by dotnet/sdk#12422

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Jul 6, 2020

There will be a central MSBuild property that can be used to configure what /warnversion is passed to the compiler.
Tentatively call AnalysisLevel for now

  • This will need to be plumbed through VS tooling including property pages
  • Would also like to remove “Warning Level” from the VS Build property pages in favor of this

Related to dotnet/roslyn#45701

@sbomer
Copy link
Member

sbomer commented Jul 23, 2020

We plan to respect AnalysisLevel for ILLink as well. Would you be able to share more details on the VS UI for this? I'm wondering if it's going to set AnalysisLevel, and whether the plan is still to remove "Warning Level" in favor of a new UI, now that the compiler implementation is reusing the /warn option instead of introducing a new /warnversion.

@jmarolf
Copy link
Contributor Author

jmarolf commented Jul 23, 2020

@sbomer as of now, the design is that /warn is only for controlling compiler produced diagnostics. AnalysisLevel is for controlling third-party tools that feed in diagnostics like analyzers (and presumably ILLink). /warn will still exist for compiler config (behind the advanced button in the UI) but I would expect the new AnalysisLevel drop down to be the main way users would configure this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants