Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Analyzer - report when Target Explicit Input list doesn't include inner Task parameters #9741

Open
baronfel opened this issue Feb 14, 2024 · 0 comments
Labels
Area: BuildCheck Feature Request Feature: Warning Waves Warnings to enable in opt-in waves. Formerly "strict mode". triaged

Comments

@baronfel
Copy link
Member

Summary

There should be an analyzer that validates that Targets that explicitly track Inputs are accounting for Properties/Items that
In dotnet/sdk#16325 we discovered that the CoreCompile Target wasn't tracking an value that was used by a Task inside the Target.

Background and Motivation

dotnet/sdk#16325 is an example of this - the $(SourceLink) property points to the generated sourcelink file, and is an input to the Csc Task inside CoreCompile, but that Property isn't captured in the Inputs of CoreCompile.

Proposed Feature

We should have an analyzer that validates this and suggests that users add specific values to the Inputs list.

Alternative Designs

No response

@baronfel baronfel added Feature Request Feature: Warning Waves Warnings to enable in opt-in waves. Formerly "strict mode". needs-triage Have yet to determine what bucket this goes in. labels Feb 14, 2024
@f-alizada f-alizada added triaged and removed needs-triage Have yet to determine what bucket this goes in. labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BuildCheck Feature Request Feature: Warning Waves Warnings to enable in opt-in waves. Formerly "strict mode". triaged
Projects
None yet
Development

No branches or pull requests

3 participants