Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shared source files #11494

Open
4 tasks
Tracked by #11241
MichalPavlik opened this issue Feb 25, 2025 · 0 comments
Open
4 tasks
Tracked by #11241

Remove shared source files #11494

MichalPavlik opened this issue Feb 25, 2025 · 0 comments
Assignees

Comments

@MichalPavlik
Copy link
Member

MSBuild repo historically uses source files shared across several projects. This is causing increased NGEN/JIT time, increased assembly size and mainly we are not able to factor our code in the right way due to type full name conflicts.

This problem could be resolved by several sequential steps/PRs:

  • Identify and resolve all resource duplicates in our projects
  • Merge all resources to a single resource file inside Microsoft.Build.Framework project. Move ResourceUtilities and ErrorUtilities to the Microsoft.Build.Framework and add AssemblyResources to make ResourceUtilities work as intended. Remove AssemblyResources files from projects with removed resources. Share the new resource file with MSBuildTaskHost and fix links to ResourceUtilities and ErrorUtilities.'
  • Remove shared files in the MSBuild project. This will unlock enablement of Microsoft.Build internal types visibility and allow us to move some logic from ``MSBuildassembly toMicrosoft.Build`.
  • Incrementally remove rest of the shared sources (move them to the Framework project)
@MichalPavlik MichalPavlik self-assigned this Feb 25, 2025
This was referenced Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant