From 0d9b0321d2c0f44dc82d7f414f062791ac55f58f Mon Sep 17 00:00:00 2001 From: Peter Collins Date: Sat, 16 Jul 2022 18:19:28 -0400 Subject: [PATCH] [workload] Remove Microsoft.Maui.Dependencies pack (#6871) Co-authored-by: Matthew Leibowitz --- Microsoft.Maui-mac.slnf | 1 - Microsoft.Maui.Packages-mac.slnf | 1 - Microsoft.Maui.Packages.slnf | 1 - Microsoft.Maui.sln | 7 --- omnisharp.json | 2 - .../Foldable/src/Controls.Foldable.csproj | 6 ++- .../Microsoft.Maui.Dependencies.csproj | 41 --------------- .../Microsoft.Maui.Sdk.csproj | 38 ++++++++++++++ .../Sdk/BundledVersions.in.targets | 51 ++++++++++++++++++- .../WorkloadManifest.in.json | 5 -- src/Workload/README.md | 1 - 11 files changed, 92 insertions(+), 62 deletions(-) delete mode 100644 src/Workload/Microsoft.Maui.Dependencies/Microsoft.Maui.Dependencies.csproj diff --git a/Microsoft.Maui-mac.slnf b/Microsoft.Maui-mac.slnf index 4e684a5e9643..9d96c6664694 100644 --- a/Microsoft.Maui-mac.slnf +++ b/Microsoft.Maui-mac.slnf @@ -54,7 +54,6 @@ "src\\Workload\\Microsoft.Maui.Controls.Runtime\\Microsoft.Maui.Controls.Runtime.csproj", "src\\Workload\\Microsoft.Maui.Core.Ref\\Microsoft.Maui.Core.Ref.csproj", "src\\Workload\\Microsoft.Maui.Core.Runtime\\Microsoft.Maui.Core.Runtime.csproj", - "src\\Workload\\Microsoft.Maui.Dependencies\\Microsoft.Maui.Dependencies.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Ref\\Microsoft.Maui.Essentials.Ref.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Runtime\\Microsoft.Maui.Essentials.Runtime.csproj", "src\\Workload\\Microsoft.Maui.Sdk\\Microsoft.Maui.Sdk.csproj", diff --git a/Microsoft.Maui.Packages-mac.slnf b/Microsoft.Maui.Packages-mac.slnf index 34849b233dac..056627707e14 100644 --- a/Microsoft.Maui.Packages-mac.slnf +++ b/Microsoft.Maui.Packages-mac.slnf @@ -20,7 +20,6 @@ "src\\Workload\\Microsoft.Maui.Sdk\\Microsoft.Maui.Sdk.csproj", "src\\Workload\\Microsoft.Maui.Core.Ref\\Microsoft.Maui.Core.Ref.csproj", "src\\Workload\\Microsoft.Maui.Core.Runtime\\Microsoft.Maui.Core.Runtime.csproj", - "src\\Workload\\Microsoft.Maui.Dependencies\\Microsoft.Maui.Dependencies.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Ref\\Microsoft.Maui.Essentials.Ref.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Runtime\\Microsoft.Maui.Essentials.Runtime.csproj", "src\\Workload\\Microsoft.NET.Sdk.Maui\\Microsoft.NET.Sdk.Maui.csproj" diff --git a/Microsoft.Maui.Packages.slnf b/Microsoft.Maui.Packages.slnf index 3fcc73150784..f2441c2fdba1 100644 --- a/Microsoft.Maui.Packages.slnf +++ b/Microsoft.Maui.Packages.slnf @@ -22,7 +22,6 @@ "src\\Workload\\Microsoft.Maui.Sdk\\Microsoft.Maui.Sdk.csproj", "src\\Workload\\Microsoft.Maui.Core.Ref\\Microsoft.Maui.Core.Ref.csproj", "src\\Workload\\Microsoft.Maui.Core.Runtime\\Microsoft.Maui.Core.Runtime.csproj", - "src\\Workload\\Microsoft.Maui.Dependencies\\Microsoft.Maui.Dependencies.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Ref\\Microsoft.Maui.Essentials.Ref.csproj", "src\\Workload\\Microsoft.Maui.Essentials.Runtime\\Microsoft.Maui.Essentials.Runtime.csproj", "src\\Workload\\Microsoft.Maui.Resizetizer.Sdk\\Microsoft.Maui.Resizetizer.Sdk.csproj", diff --git a/Microsoft.Maui.sln b/Microsoft.Maui.sln index d72c53c9d7ea..e846f6a1c298 100644 --- a/Microsoft.Maui.sln +++ b/Microsoft.Maui.sln @@ -80,8 +80,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Maui.Core.Ref", " EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Maui.Core.Runtime", "src\Workload\Microsoft.Maui.Core.Runtime\Microsoft.Maui.Core.Runtime.csproj", "{73075C7E-AA0A-4FD6-BBD7-6BD3B43BC2A9}" EndProject -Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Maui.Dependencies", "src\Workload\Microsoft.Maui.Dependencies\Microsoft.Maui.Dependencies.csproj", "{582BA9EC-420C-4512-8892-37E8F6D1E70F}" -EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Maui.Essentials.Ref", "src\Workload\Microsoft.Maui.Essentials.Ref\Microsoft.Maui.Essentials.Ref.csproj", "{28B1E6A8-4EB7-4B82-9552-10C418692496}" EndProject Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.Maui.Essentials.Runtime", "src\Workload\Microsoft.Maui.Essentials.Runtime\Microsoft.Maui.Essentials.Runtime.csproj", "{C69336DF-EE56-4236-8188-06B2A8AD8A36}" @@ -304,10 +302,6 @@ Global {73075C7E-AA0A-4FD6-BBD7-6BD3B43BC2A9}.Debug|Any CPU.Build.0 = Debug|Any CPU {73075C7E-AA0A-4FD6-BBD7-6BD3B43BC2A9}.Release|Any CPU.ActiveCfg = Release|Any CPU {73075C7E-AA0A-4FD6-BBD7-6BD3B43BC2A9}.Release|Any CPU.Build.0 = Release|Any CPU - {582BA9EC-420C-4512-8892-37E8F6D1E70F}.Debug|Any CPU.ActiveCfg = Debug|Any CPU - {582BA9EC-420C-4512-8892-37E8F6D1E70F}.Debug|Any CPU.Build.0 = Debug|Any CPU - {582BA9EC-420C-4512-8892-37E8F6D1E70F}.Release|Any CPU.ActiveCfg = Release|Any CPU - {582BA9EC-420C-4512-8892-37E8F6D1E70F}.Release|Any CPU.Build.0 = Release|Any CPU {28B1E6A8-4EB7-4B82-9552-10C418692496}.Debug|Any CPU.ActiveCfg = Debug|Any CPU {28B1E6A8-4EB7-4B82-9552-10C418692496}.Debug|Any CPU.Build.0 = Debug|Any CPU {28B1E6A8-4EB7-4B82-9552-10C418692496}.Release|Any CPU.ActiveCfg = Release|Any CPU @@ -531,7 +525,6 @@ Global {C5C434A7-4E1F-456F-A23A-F2566C98301A} = {EC63FD88-5E12-46D7-B440-68F70241D987} {359FFDAC-3E3C-4A78-98EE-9070841E5792} = {EC63FD88-5E12-46D7-B440-68F70241D987} {73075C7E-AA0A-4FD6-BBD7-6BD3B43BC2A9} = {EC63FD88-5E12-46D7-B440-68F70241D987} - {582BA9EC-420C-4512-8892-37E8F6D1E70F} = {EC63FD88-5E12-46D7-B440-68F70241D987} {28B1E6A8-4EB7-4B82-9552-10C418692496} = {EC63FD88-5E12-46D7-B440-68F70241D987} {C69336DF-EE56-4236-8188-06B2A8AD8A36} = {EC63FD88-5E12-46D7-B440-68F70241D987} {02414DF4-FBE9-400B-8F3F-40DDC7F8FEFC} = {EC63FD88-5E12-46D7-B440-68F70241D987} diff --git a/omnisharp.json b/omnisharp.json index e4b0a3cf074e..45c2fd43b9a1 100644 --- a/omnisharp.json +++ b/omnisharp.json @@ -29,8 +29,6 @@ "src/Workload/Microsoft.Maui.Controls.Runtime/Microsoft.Maui.Controls.Runtime.csproj", "src/Workload/Microsoft.Maui.Core.Runtime/Microsoft.Maui.Core.Runtime.csproj", "src/Workload/Microsoft.Maui.Essentials.Ref/Microsoft.Maui.Essentials.Ref.csproj", - "src/Workload/Microsoft.Maui.Dependencies/Microsoft.Maui.Dependencies.csproj", - "Microsoft.Maui.Packages.slnf", "Microsoft.Maui.Samples.slnf", "Microsoft.Maui.sln", diff --git a/src/Controls/Foldable/src/Controls.Foldable.csproj b/src/Controls/Foldable/src/Controls.Foldable.csproj index 5363bb0bc29e..1b5a2c1d0ebf 100644 --- a/src/Controls/Foldable/src/Controls.Foldable.csproj +++ b/src/Controls/Foldable/src/Controls.Foldable.csproj @@ -9,7 +9,7 @@ true - + @@ -22,10 +22,12 @@ - + + + diff --git a/src/Workload/Microsoft.Maui.Dependencies/Microsoft.Maui.Dependencies.csproj b/src/Workload/Microsoft.Maui.Dependencies/Microsoft.Maui.Dependencies.csproj deleted file mode 100644 index ff280fc84f6b..000000000000 --- a/src/Workload/Microsoft.Maui.Dependencies/Microsoft.Maui.Dependencies.csproj +++ /dev/null @@ -1,41 +0,0 @@ - - - - $(MSBuildProjectName) - .NET MAUI NuGet dependencies pack - $(_MauiDotNetTfm);$(MauiPlatforms) - false - false - false - $(NoWarn);NU5128;NU5104; - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/src/Workload/Microsoft.Maui.Sdk/Microsoft.Maui.Sdk.csproj b/src/Workload/Microsoft.Maui.Sdk/Microsoft.Maui.Sdk.csproj index fb87f595de0b..9342c855c802 100644 --- a/src/Workload/Microsoft.Maui.Sdk/Microsoft.Maui.Sdk.csproj +++ b/src/Workload/Microsoft.Maui.Sdk/Microsoft.Maui.Sdk.csproj @@ -63,9 +63,15 @@ <_ValuesToReplace Include="MAUI_PREVIOUS_DOTNET_VERSION" PropertyName="_MauiPreviousDotNetVersion" /> <_ValuesToReplace Include="MAUI_PREVIOUS_DOTNET_VERSION_NO_DOT" PropertyName="_MauiPreviousDotNetVersionNoDot" /> <_ValuesToReplace Include="MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION" PropertyName="MicrosoftMauiPreviousDotNetReleasedVersion" /> + <_ValuesToReplace Include="MicrosoftWindowsAppSDKPackageVersion" PropertyName="MicrosoftWindowsAppSDKPackageVersion" /> <_ValuesToReplace Include="MicrosoftWindowsSDKBuildToolsPackageVersion" PropertyName="MicrosoftWindowsSDKBuildToolsPackageVersion" /> <_ValuesToReplace Include="MicrosoftExtensionsPackageVersion" PropertyName="MicrosoftExtensionsPackageVersion" /> <_ValuesToReplace Include="MicrosoftExtensionsServicingPackageVersion" PropertyName="MicrosoftExtensionsServicingPackageVersion" /> + <_ValuesToReplace Include="MicrosoftMauiGraphicsVersion" PropertyName="MicrosoftMauiGraphicsVersion" /> + <_ValuesToReplace Include="TizenUIExtensionsVersion" PropertyName="TizenUIExtensionsVersion" /> + <_ValuesToReplace Include="_XamarinAndroidGlideVersion" PropertyName="_XamarinAndroidGlideVersion" /> + <_ValuesToReplace Include="_XamarinAndroidXSecurityVersion" PropertyName="_XamarinAndroidXSecurityVersion" /> + <_ValuesToReplace Include="_XamarinGoogleCryptoTinkAndroidVersion" PropertyName="_XamarinGoogleCryptoTinkAndroidVersion" /> @@ -75,6 +81,38 @@ DependsOnTargets="SetVersions" Inputs="$(MSBuildProjectFile);$(MauiRootDirectory)eng/Versions.props;Sdk/BundledVersions.in.targets" Outputs="$(IntermediateOutputPath)BundledVersions.targets"> + + + + + + + + + + + + + + + + + <_ValuesToReplace Include="_XamarinAndroidXBrowserVersion" PropertyName="_XamarinAndroidXBrowserVersion" /> + <_ValuesToReplace Include="_XamarinAndroidXLegacySupportV4Version" PropertyName="_XamarinAndroidXLegacySupportV4Version" /> + <_ValuesToReplace Include="_XamarinAndroidXLifecycleLiveDataVersion" PropertyName="_XamarinAndroidXLifecycleLiveDataVersion" /> + <_ValuesToReplace Include="_XamarinAndroidXNavigationVersion" PropertyName="_XamarinAndroidXNavigationVersion" /> + <_ValuesToReplace Include="_XamarinGoogleAndroidMaterialVersion" PropertyName="_XamarinGoogleAndroidMaterialVersion" /> + - + all + + + all + + + all + + + all + + + all + + + all + + + all + + + all + + + all + + + all + + + all + + + all + + + + + all + + + all + + all + + all + + + all + diff --git a/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json b/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json index 9f1887fc868b..c5ef92d6e25f 100644 --- a/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json +++ b/src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.json @@ -27,7 +27,6 @@ "abstract": true, "description": ".NET MAUI SDK Core Packages", "packs": [ - "Microsoft.Maui.Dependencies", "Microsoft.Maui.Sdk", "Microsoft.Maui.Sdk-@MAUI_PREVIOUS_DOTNET_VERSION@", "Microsoft.Maui.Graphics", @@ -224,10 +223,6 @@ "kind": "framework", "version": "@VERSION@" }, - "Microsoft.Maui.Dependencies": { - "kind": "library", - "version": "@VERSION@" - }, "Microsoft.Maui.Essentials.Ref.any": { "kind": "framework", "version": "@VERSION@" diff --git a/src/Workload/README.md b/src/Workload/README.md index 03ccd066c076..f5f98efb3680 100644 --- a/src/Workload/README.md +++ b/src/Workload/README.md @@ -23,7 +23,6 @@ The idea, is a project to be able to set `$(UseMaui)`: * `Microsoft.Maui.Core.Runtime.[platform]` * `Microsoft.Maui.Controls.Ref.[platform]` * `Microsoft.Maui.Controls.Runtime.[platform]` -* `Microsoft.Maui.Dependencies` * `Microsoft.Maui.Essentials.Ref.[platform]` * `Microsoft.Maui.Essentials.Runtime.[platform]` * `Microsoft.Maui.Templates`