Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate and fix test failures #1131

Closed
Zruty0 opened this issue Oct 3, 2018 · 3 comments
Closed

Investigate and fix test failures #1131

Zruty0 opened this issue Oct 3, 2018 · 3 comments
Labels
bug Something isn't working Build Build related issue test related to tests

Comments

@Zruty0
Copy link
Contributor

Zruty0 commented Oct 3, 2018

Our commit success rate is below 50% at this point.

We no longer have the annoying deadlock plaguing the builds, but somehow the builds are still failing quite often. Let's spend some time and improve that story.

From casual look, there is no single culprit: we seem to randomly fail to initialize build environment, and random tests seem to fail in random places. I guess this may have to do with resource-constrained runs: maybe we should actually try running xUnit tests sequentially and see if the sporadic failures go away?

@justinormont justinormont added Build Build related issue test related to tests labels Oct 4, 2018
@Ivanidzo4ka
Copy link
Contributor

Ivanidzo4ka commented Oct 5, 2018

Should we at least create list of failing tests?
Let me start it:
MulticlassTreeFeaturizedLRTest - MacOS - Debug
System.InvalidOperationException : MTA thread failed
---- Assert.InRange() Failure
Range: (74.9925 - 75.0075)
Actual: 72

MultithreadedPrediction - MacOS - Debug
at Microsoft.ML.Runtime.Contracts.CheckDecode(IExceptionContext ctx, Boolean f) in Microsoft.ML.Core/Utilities/Contracts.cs:line 713
at Microsoft.ML.Runtime.Model.ModelLoadContext.LoadNonEmptyString() in Microsoft.ML.Data/Model/ModelLoadContext.cs:line 163
at Microsoft.ML.Runtime.Data.TermTransform.TermMap.TextImpl.Create(ModelLoadContext ctx, IExceptionContext ectx) in /Microsoft.ML.Data/Transforms/TermTransformImpl.cs:line 603
at Microsoft.ML.Runtime.Data.TermTransform.TermMap.Load(ModelLoadContext ctx, IHostEnvironment ectx, CodecFactory codecFactory) in /Microsoft.ML.Data/Transforms/TermTransformImpl.cs:line 518

FastTreeBinaryClassificationCategoricalSplitTest MacOS - Debug

at Microsoft.ML.Runtime.RunTests.BaseTestBaseline.Done() in /Users/buildagent/agent/_work/1/s/test/Microsoft.ML.TestFramework/BaseTestBaseline.cs:line 149
at Microsoft.ML.Runtime.RunTests.TestPredictors.FastTreeBinaryClassificationCategoricalSplitTest() in /Users/buildagent/agent/_work/1/s/test/Microsoft.ML.Predictor.Tests/TestPredictors.cs:line 725

TrainAndPredictIrisModelWithStringLabelTest MacOS - Debug
Assert failed: longIdx=133, invariants.Length=133
Expected: True
Actual: False
at Microsoft.ML.Runtime.Learners.SdcaTrainerBase2.TrainCore(IChannel ch, RoleMappedData data, LinearPredictor predictor, Int32 weightSetCount) in /src/Microsoft.ML.StandardLearners/Standard/LinearClassificationTrainer.cs:line 517 at Microsoft.ML.Runtime.Learners.StochasticTrainerBase2.TrainModelCore(TrainContext context) in /src/Microsoft.ML.StandardLearners/Standard/StochasticTrainerBase.cs:line 42

@Zruty0 Zruty0 added the bug Something isn't working label Oct 12, 2018
@Zruty0
Copy link
Contributor Author

Zruty0 commented Oct 15, 2018

@montebhoover , would you mind taking a look?

@frank-dong-ms-zz
Copy link
Contributor

These issues are fixed recently, some race condition issues.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Build Build related issue test related to tests
Projects
None yet
Development

No branches or pull requests

6 participants