Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roslyn analyzers need to register necessary MSBuild properties with the compiler #1745

Closed
agocke opened this issue Jan 12, 2021 · 1 comment
Closed

Roslyn analyzers need to register necessary MSBuild properties with the compiler #1745

agocke opened this issue Jan 12, 2021 · 1 comment
Assignees
@tlakollo
Labels
area-Integration: netcore
Milestone
6.0.x

Comments

@agocke
Copy link
Member

agocke commented Jan 12, 2021

See https://github.com/dotnet/roslyn-analyzers/blob/4ce9cd5efe21ab9e0eabfd4eb3565cd2dde76b35/src/Tools/GenerateDocumentationAndConfigFiles/Program.cs#L1457

Basically, only properties which are marked CompilerVisibleProperty will get copied over. We can create a .props file for our NuGet package to automatically register all the MSBuild properties we need.
@marek-safar marek-safar added this to the .NET 6.0 milestone Jan 13, 2021
@agocke agocke mentioned this issue Jan 13, 2021
Merged
@tlakollo
Copy link
Contributor

Closing via #1767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlakollo tlakollo

Labels
area-Integration: netcore
Projects
None yet
Milestone
6.0.x
Development

No branches or pull requests
3 participants
@marek-safar @agocke @tlakollo