Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemory: Avoid server evaluating client functions #17050

Closed
smitpatel opened this issue Aug 9, 2019 · 4 comments
Closed

InMemory: Avoid server evaluating client functions #17050

smitpatel opened this issue Aug 9, 2019 · 4 comments
Labels
area-in-memory area-query closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@smitpatel
Copy link
Contributor

Currently any function is server evaluatable for in memory. So we end up sending client functions to server also. That means we may be potentially causing memory leak.
We need to determine if inmemory should server eval client functions and if it does, how to avoid memory leaks.
@ajcvickers ajcvickers added this to the Backlog milestone Aug 9, 2019
@smitpatel
Copy link
Contributor Author

smitpatel commented Aug 23, 2019 •
edited
Loading

Fixed in #17366

@smitpatel smitpatel removed this from the Backlog milestone Aug 23, 2019
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 23, 2019
@smitpatel smitpatel self-assigned this Aug 23, 2019
@smitpatel smitpatel reopened this Aug 23, 2019
@smitpatel
Copy link
Contributor Author

Linking to #16963

@smitpatel
Copy link
Contributor Author

Wrong issue. 🤦‍♂

@smitpatel smitpatel removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 23, 2019
@smitpatel smitpatel removed their assignment Aug 23, 2019
@smitpatel smitpatel added this to the Backlog milestone Aug 23, 2019
@smitpatel smitpatel mentioned this issue Aug 24, 2019
Closed
@smitpatel
Copy link
Contributor Author

When implementing this, also account for function with DbFunctionAttribute. They should go to server eval like they do on other databases.

@smitpatel smitpatel mentioned this issue Oct 22, 2019
Merged
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0 Nov 5, 2020
@smitpatel smitpatel removed this from the 6.0.0 milestone Nov 6, 2020
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-in-memory area-query closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel