Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all logging, diagnostics, and interception to be turned off #16197

Closed
ajcvickers opened this issue Jun 21, 2019 · 3 comments
Closed

Allow all logging, diagnostics, and interception to be turned off #16197

ajcvickers opened this issue Jun 21, 2019 · 3 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@ajcvickers
Copy link
Contributor

Implement a fast early bailout that means we don't do any of these thing and will avoid even initializing anything needed for these things.
@ajcvickers
Copy link
Contributor Author

Or consider having a Flags enum to enable just the part you want.

@ajcvickers ajcvickers added this to the Backlog milestone Jun 24, 2019
@ajcvickers ajcvickers self-assigned this Jun 24, 2019
@ajcvickers
Copy link
Contributor Author

Consider not creating correlation IDs or timers when logging is not being used: see #16716 (review)

@ajcvickers ajcvickers mentioned this issue Jul 25, 2019
Merged
@ajcvickers ajcvickers mentioned this issue Feb 22, 2021
Closed
@ajcvickers ajcvickers removed this from the Backlog milestone Apr 19, 2021
@roji
Copy link
Member

roji commented Apr 21, 2021

Probably not needed after #24304.

@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ajcvickers @roji