Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Include should use a robust way to identity nullable QSRE in IncludeResultOperator #10104

Closed
smitpatel opened this issue Oct 17, 2017 · 2 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-cleanup

Comments

@smitpatel
Copy link
Contributor

While fixing #10045, we added nullable and convert node around QSRE because during include we lack the information about QSRE. As a side effect during SelectExpression.AddToOrderBy we need to pattern match both ways apart from expressionEqualityComparer. Same is the case in Distinct erasing order by or include trying to find if projection/orderby has been added or not.
Instead we should try to accurately find out nullability of QSRE in include so that rest of stack can be consistent about it and does not require to look for multiple patterns when searching.

@ajcvickers ajcvickers added this to the Backlog milestone Oct 18, 2017
@AndriySvyryd
Copy link
Member

@smitpatel not needed?

@smitpatel
Copy link
Contributor Author

Not needed

  • No QSRE
  • No Query model
  • No split queries for include which would add orderings
  • No convert nodes in SQL tree

@AndriySvyryd AndriySvyryd removed this from the Backlog milestone Aug 22, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. type-cleanup
Projects
None yet
Development

No branches or pull requests

3 participants