Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dotnet_analyzer_diagnostic.category Documentation #22248

Closed
RehanSaeed opened this issue Nov 15, 2020 · 5 comments · Fixed by #25562
Closed

Improve dotnet_analyzer_diagnostic.category Documentation #22248

RehanSaeed opened this issue Nov 15, 2020 · 5 comments · Fixed by #25562

Comments

@RehanSaeed
Copy link

RehanSaeed commented Nov 15, 2020

The official documentation does not mention dotnet_analyzer_diagnostic.category-CodeQuality.severity but it exists in Roslyn Analyzers here: https://github.com/dotnet/roslyn-analyzers/blob/master/.editorconfig#L185-L239.

This documentation mentions that there are categories for rules and mentions 'Performance' but fails to list the categories.

Is there a list of categories we can see?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@twastvedt
Copy link

I had some success looking at the titles for the various pages nested next to this one: https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/. Same for the neighboring style rules. For example, there's a page "Performance rules" which lists the rules in the "-performance" category. Not sure how that translates to the categories with multiple words in their names. I also found I could address all style rules with the "-style" category.

But I agree that more explicit documentation would be helpful.

@mavasani mavasani transferred this issue from dotnet/roslyn-analyzers Jan 6, 2021
@dotnet-bot dotnet-bot added the ⌚ Not Triaged Not triaged label Jan 6, 2021
@PRMerger7 PRMerger7 added the Pri3 label Jan 6, 2021
@mavasani
Copy link
Contributor

mavasani commented Jan 6, 2021

Also tagging @gewarren and @mikadumont

We ship CA code quality analyzers and IDE code style analyzers with .NET SDK, starting version 5.0
The rules shipping in these SDK have specific categories. We have editorconfig support and documentation to enable/disable rules based on categories (see here). With .NET SDK 6.0, we will also have MSBuild support for category based configuration (see here)

We should add both these pieces of documentation:

  1. Explicitly list the set of categories for CA and IDE rules shipping with the .NET SDK
  2. Documentation for new MSBuild support for category based configuration.

@mavasani mavasani self-assigned this Jan 6, 2021
@gewarren gewarren added doc-enhancement and removed ⌚ Not Triaged Not triaged labels Jan 6, 2021
@RehanSaeed
Copy link
Author

The documentation should also list which version of Visual Studio you need to use the new severity setting.

@christopherpross
Copy link

well, are there updates here? I want to enable some categories, but I didn't know the name of them in the Editorconfig.
It would be nice, if this could be documented.

@gewarren gewarren added Pri1 and removed Pri3 labels Aug 3, 2021
@gewarren gewarren self-assigned this Aug 3, 2021
@gewarren
Copy link
Contributor

gewarren commented Aug 3, 2021

Thanks for the ping. I'll try to make these updates this month (August).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants