Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8.0 RC2 #8828

Closed
rbhanda opened this issue Oct 10, 2023 · 6 comments
Closed

.NET 8.0 RC2 #8828

rbhanda opened this issue Oct 10, 2023 · 6 comments

Comments

@rbhanda
Copy link
Contributor

rbhanda commented Oct 10, 2023

Release Notes

Please report any issues you find with .NET 8 RC 2, either responding to this issue, creating a new issue or creating a new issue in one of the following repos:

Known Issues

If there are any issues with this release we will track them here and check issues off as they're resolved. See the linked issues for details on progress and resolution details.

@rbhanda rbhanda pinned this issue Oct 10, 2023
@rbhanda rbhanda mentioned this issue Oct 10, 2023
@thabaum
Copy link

thabaum commented Oct 10, 2023

MITRE: CVE-2023-44487 HTTP/2 Rapid Reset Attack

Check spelling for "Kestral" as it should be "Kestrel" and is mentioned twice referred to as Kestral on these two lines:

Include a protocols setting for each Kestral endpoint to limit your application to HTTP1.1

and the following line:

For .NET and Kestral, servers without HTTP/2 enabled are not affected. To limit your application to HTTP1.1 via config, edit your appsettings.json to include a protocols setting for each endpoint:

@mairaw
Copy link
Contributor

mairaw commented Oct 10, 2023

Thank you for your feedback @thabaum. I'm reaching out to some folks internally to help with that.

@eduherminio
Copy link
Member

eduherminio commented Oct 10, 2023

According to #8439 (comment) this piece code was needed for RC1 to make configuration binder source generator work, but it would no longer be needed for RC2 and onwards.

<Features>$(Features);InterceptorsPreview</Features>

However, (even without removing it), I'm facing with this build error:

Error: /Users/runner/work/my_repo_dir/Microsoft.Extensions.Configuration.Binder.SourceGeneration/Microsoft.Extensions.Configuration.Binder.SourceGeneration.ConfigurationBindingGenerator/BindingExtensions.g.cs(35,10): error CS9137:
The 'interceptors' experimental feature is not enabled in this namespace.
Add '<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.Extensions.Configuration.Binder.SourceGeneration</InterceptorsPreviewNamespaces>' to your project. [/Users/runner/work/my_repo_dir/MyProject.csproj]

If I'm not wrong, that isn't mentioned in the package README or the RC2 article announcement.

Is that the intended behavior? If that's the case, it's probably worth mentioning in the places mentioned above.

cc/ @layomia

PD: following the instructions does fix the issue.

@WeihanLi
Copy link
Contributor

WeihanLi commented Oct 11, 2023

@mairaw
Copy link
Contributor

mairaw commented Oct 12, 2023

@thabaum the CVE page was updated. Thanks for letting us know!

@rbhanda rbhanda unpinned this issue Nov 14, 2023
@rbhanda
Copy link
Contributor Author

rbhanda commented Nov 14, 2023

Closing in favor of #8904

@rbhanda rbhanda closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants