Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to scaffold identity endpoints in project and override these #53343

Open
1 task done
shakeel19 opened this issue Jan 13, 2024 · 5 comments
Open
1 task done
Labels
area-identity Includes: Identity and providers enhancement This issue represents an ask for new feature or an enhancement to an existing one

Comments

@shakeel19
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The solution to provide the API endpoints with .net core 8 is great feature, We have considered to use this feature in our new project that we are going to kick in couple of months.
The issue that APIs provide very basic functionality ie register endpoint only accepting email and password to create user. But in real world scenario there could be are some other attributes which could be required at time of registration there are many examples.

Describe the solution you'd like

My suggestion is to instead of keeping this implementation hidden, there should be option to scaffold is in the project so that a developer can override its functionality according to requirements. Optionally it should be allowed to scaffolded selected endpoints.
The similar feature available with razor pages where developer can override the selected views for identity, this is best option for razor based application but not SPA applications.
I have gone through many other issues as well and I believe some issues will solved when developers will have option to override the API.

Additional context

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 13, 2024
@shakeel19
Copy link
Author

Hi @halter73 please give your suggestions on this.

@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 6, 2024
@wtgodbe wtgodbe removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@dotnet dotnet deleted a comment from dotnet-policy-service bot Feb 13, 2024
@AlejandroMFe
Copy link

Hi 👋😁 @shakeeldev3,
I think this is a great approach for the Identity API endpoints.
From this approach, we can:

  • Select which endpoints to use
  • Override the implementation
  • Adapt flexibly for custom scenarios
  • Generate separate files, so we don't compromise the project
  • Above all, Don't repeat yourself

Great @shakeeldev3 thanks for sharing your idea👏🏽🙏

Hi @JeremyLikness, can you check this please?
Thanks!🙏

@JeremyLikness
Copy link
Member

Thanks @AlejandroMFe and @shakeeldev3 I see this and will review with the team.

@halter73 halter73 added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-identity Includes: Identity and providers and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Dec 20, 2024
@halter73 halter73 added this to the .NET 10 Planning milestone Dec 20, 2024
@halter73
Copy link
Member

It looks like #58959 is a duplicate of this. I think we searched for the terms "scaffold" and "MapIdentityApi", so this didn't come up. We plan to do this for .NET 10 though!

@Misiu
Copy link

Misiu commented Jan 23, 2025

This would be very useful.
In a new project I'd like to use the new identity endpoint, but sadly manage/info isn't returning claims and roles anymore.
I fully agree, that security must be done on both frontend and backend, but I show/hide some options on the frontend based on claims and roles (I do the validation on the backend as well).
For now, I created a custom backend, but there should be an option that will allow us to add roles and claims to the response

@danroth27 danroth27 changed the title Add ability to scaffold .Net core 8 api endpoints in project and override these Add ability to scaffold identity endpoints in project and override these Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Development

No branches or pull requests

6 participants