Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Razor SDK dependency in StaticWebAssets SDK #47374

Closed
MackinnonBuck opened this issue Mar 22, 2023 · 1 comment · Fixed by dotnet/sdk#32047
Closed

Remove Razor SDK dependency in StaticWebAssets SDK #47374

MackinnonBuck opened this issue Mar 22, 2023 · 1 comment · Fixed by dotnet/sdk#32047
Assignees
@MackinnonBuck
Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-sdk
Milestone
8.0-preview5

Comments

@MackinnonBuck
Copy link
Member

There are places where the StaticWebAssets SDK depends on targets defined in the Razor SDK: https://github.com/search?q=repo%3Adotnet%2Fsdk+AssignRazorComponentTargetPaths+lang%3Axml&type=code

Ideally, we would only want the dependency to exist in the other direction.

See dotnet/sdk#31359 for more discussion.
@MackinnonBuck MackinnonBuck added enhancement This issue represents an ask for new feature or an enhancement to an existing one area-blazor Includes: Blazor, Razor Components feature-razor-sdk labels Mar 22, 2023
@MackinnonBuck MackinnonBuck added this to the 8.0-preview4 milestone Mar 22, 2023
@MackinnonBuck MackinnonBuck self-assigned this Mar 22, 2023
@MackinnonBuck MackinnonBuck mentioned this issue Mar 22, 2023
Closed
@MackinnonBuck
Copy link
Member Author

See also: dotnet/sdk#31559 (comment)

This was referenced Apr 19, 2023
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MackinnonBuck MackinnonBuck

Labels
area-blazor Includes: Blazor, Razor Components enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-razor-sdk
Projects
None yet
Milestone
8.0-preview5
Development

Successfully merging a pull request may close this issue.

Follow-up to #31559 dotnet/sdk
3 participants
@MackinnonBuck @mkArtakMSFT and others