Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to ensure interop with Microsoft.Owin.Security and aspnetcore 3.0+ works #4074

Closed
natemcmaster opened this issue Nov 17, 2018 · 1 comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Nov 17, 2018

In aspnet/Security#1916, we had to entirely disable Owin cookie interop tests as a result of changing target framework support. We should re-write these tests in a way that lets us test the supported scenarios without requiring a hack to run aspnetcore assemblies on .NET Framework.

The scenarios we need to ensure continue to work are:

  • Cookies and keys created by ASP.NET Core 3.0+ interop with Owin/Katana using Microsoft.Owin.Security.Interop 2.1.
  • Vice versa
  • Any changes to cookie formats and key formats made in 3.0+ stay backwards compatible with DataProtection 2.1
@natemcmaster natemcmaster added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Nov 17, 2018
@natemcmaster natemcmaster changed the title Rewrite owin cookie interop tests for 3.0 Add test coverage to ensure interop with Owin and aspnetcore 3.0+ works Nov 28, 2018
@natemcmaster natemcmaster added this to the 3.0.0-preview3 milestone Nov 28, 2018
@natemcmaster natemcmaster added the area-dataprotection Includes: DataProtection label Nov 28, 2018
@Tratcher Tratcher changed the title Add test coverage to ensure interop with Owin and aspnetcore 3.0+ works Add test coverage to ensure interop with Microsoft.Owin.Security and aspnetcore 3.0+ works Nov 29, 2018
@natemcmaster natemcmaster self-assigned this Dec 3, 2018
@Eilon Eilon modified the milestones: 3.0.0-preview2, 3.0.0-preview3 Dec 20, 2018
@muratg muratg removed the area-dataprotection Includes: DataProtection label Jan 8, 2019
@Eilon Eilon modified the milestones: 3.0.0-preview3, 3.0.0-preview5 Feb 7, 2019
@Eilon Eilon modified the milestones: 3.0.0-preview5, 3.0.0-preview6 Mar 26, 2019
@Eilon
Copy link
Member

Eilon commented Mar 26, 2019

Closing because we don't have plans to continue supporting this scenario.

@Eilon Eilon closed this as completed Mar 26, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer
Projects
None yet
Development

No branches or pull requests

3 participants