Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port dotnet-run's DOTNET_ROOT changes to dotnet-watch #35793

Closed
pranavkm opened this issue Aug 26, 2021 · 2 comments
Closed

Port dotnet-run's DOTNET_ROOT changes to dotnet-watch #35793

pranavkm opened this issue Aug 26, 2021 · 2 comments
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) feature-hot-reload This issue is related to the Hot Reload feaature Priority:1 Work that is critical for the release, but we could probably ship without task
Milestone
.NET 8 Planning

Comments

@pranavkm
Copy link
Contributor

dotnet-run update Commit: dotnet/sdk@36e9be0

Code that needs to be updated: https://github.com/dotnet/sdk/blob/f7c1dea665f46f0f47e88ff2b33da3bd13f7d0a5/src/BuiltInTools/dotnet-watch/HotReloadDotNetWatcher.cs#L269
@pranavkm pranavkm added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Aug 26, 2021
@pranavkm
Copy link
Contributor Author

FYI @agocke

@pranavkm pranavkm modified the milestone: 6.0-rc2 Aug 26, 2021
@mkArtakMSFT mkArtakMSFT added the enhancement This issue represents an ask for new feature or an enhancement to an existing one label Aug 30, 2021
@mkArtakMSFT mkArtakMSFT added this to the 6.0-rc2 milestone Aug 30, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0-rc2, 6.0.0 Sep 8, 2021
@mkArtakMSFT mkArtakMSFT added the feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) label Sep 21, 2021
@pranavkm pranavkm added the feature-hot-reload This issue is related to the Hot Reload feaature label Oct 4, 2021
@pranavkm pranavkm removed their assignment Oct 18, 2021
@mkArtakMSFT mkArtakMSFT modified the milestones: 6.0.0, .NET 7 Planning Nov 2, 2021
@mkArtakMSFT mkArtakMSFT added triaged Priority:1 Work that is critical for the release, but we could probably ship without labels Nov 2, 2021
@ghost
Copy link

ghost commented Sep 14, 2022

Thanks for contacting us.

We're moving this issue to the .NET 8 Planning milestone for future evaluation / consideration. We would like to keep this around to collect more feedback, which can help us with prioritizing this work. We will re-evaluate this issue, during our next planning meeting(s).
If we later determine, that the issue has no community involvement, or it's very rare and low-impact issue, we will close it - so that the team can focus on more important and high impact issues.
To learn more about what to expect next and how this issue will be handled you can read more about our triage process here.

@tmat tmat mentioned this issue Sep 19, 2022
Merged
@tmat tmat closed this as completed Mar 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI enhancement This issue represents an ask for new feature or an enhancement to an existing one feature-dotnetwatch This issue is related to the dotnet-watch command-line tool (now external) feature-hot-reload This issue is related to the Hot Reload feaature Priority:1 Work that is critical for the release, but we could probably ship without task
Projects
None yet
Milestone
.NET 8 Planning
Development

No branches or pull requests
4 participants
@tmat @pranavkm @TanayParikh @mkArtakMSFT