Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] KeyRingProvider initialization causes thread pool starvation when server starts under load #2510

Closed
aspnet-hello opened this issue Jan 1, 2018 · 4 comments
Labels
area-dataprotection Includes: DataProtection

Comments

@aspnet-hello
Copy link

From @natemcmaster on Friday, June 2, 2017 6:08:19 PM

Consider back-porting aspnet/DataProtection#241 to 1.x.

cref original issue #233 (fixed for 2.0)

Copied from original issue: aspnet/DataProtection#242

@aspnet-hello
Copy link
Author

From @brockallen on Friday, June 2, 2017 6:12:43 PM

Sorry, repeating from the PR:

Ok, thanks. One my my customers was on the original issue/thread here, and from their perspective data protection is in essence broken and unusable until this fix makes it into a release (as I'd imagine anyone else trying to use data protection, especially in azure). They aren't really in a position to move to 2.0 anytime soon.

@aspnet-hello aspnet-hello added the area-dataprotection Includes: DataProtection label Jan 1, 2018
@aspnet-hello
Copy link
Author

From @Tratcher on Friday, June 2, 2017 6:28:03 PM

Looks like there's a trivial workaround, does it have any catches?

@aspnet-hello
Copy link
Author

From @brockallen on Friday, June 2, 2017 6:34:32 PM

Looks like there's a trivial workaround, does it have any catches?

Well, I can only say that my customer was close to dropping ASP.NET Core support (and going back to the ancient days of Katana even!) given that this felt like a critical issue "out of the box". Perhaps fixing perception is more important?

@blowdart
Copy link
Contributor

blowdart commented Feb 2, 2018

@Eilon says back porting is not going to happen

@blowdart blowdart closed this as completed Feb 2, 2018
@ghost ghost locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-dataprotection Includes: DataProtection
Projects
None yet
Development

No branches or pull requests

2 participants