-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the expected workflow for Symbols Validation of official releases? #15537
Comments
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
The validation itself is part of the staging/release pipeline - that'd be on Prague's ProdCon plate with our release team here. If the infra makes the right validation but we don't pass it, this is definitely something for repo owners to go triage. Things get complex fast (what repo does r2r vs not, how do they ship symbols, etc). But a simple "all packages should have a symbol for all entries, unless explicitly in the symbol exclusion list". |
I agree with Juan - validation should be part of the pipeline that publishes the symbol, which is the staging and release pipelines. As Juan points out, we sometimes index multiple symbols to one shipping binary. These specialized requirements are documented on https://github.com/dotnet/diagnostics/blob/main/documentation/symbols/README.md. Our team (.net runtime diagnostics) should be able to work with the staging/release pipeline owners to ensure that those requirements are being validated. |
Who needs to take action on this to fix it? Can you tag them? |
Description
We were looking at the results of https://dev.azure.com/dnceng/internal/_build?definitionId=1303&_a=summary and see many failures.
Who's meant to review these and file issues or follow up on the failures? @michalpavelka @mmitche
We noticed many symbol failures but it's hard to know if those are real problems or issues with the pipeline.
Reproduction Steps
Examine failures in https://dev.azure.com/dnceng/internal/_build?definitionId=1303&_a=summary
Expected behavior
Most release builds are green - for any failures issues are filed.
Actual behavior
Many failing validation checks, unclear if they are actionable failures or not.
Regression?
???
Known Workarounds
No response
Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: