Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonitoringStream.DidFlush event #149

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Add MonitoringStream.DidFlush event #149

merged 1 commit into from
Dec 9, 2019

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Dec 9, 2019

Closes #131

@AArnott AArnott added this to the v2.5 milestone Dec 9, 2019
@AArnott AArnott self-assigned this Dec 9, 2019
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #149 into master will increase coverage by 3.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   87.35%   90.66%   +3.31%     
==========================================
  Files          33       34       +1     
  Lines        2380     2433      +53     
==========================================
+ Hits         2079     2206     +127     
+ Misses        301      227      -74
Impacted Files Coverage Δ
src/Nerdbank.Streams/MonitoringStream.cs 100% <100%> (ø) ⬆️
src/Nerdbank.Streams/Substream.cs 100% <0%> (ø) ⬆️
src/Nerdbank.Streams/SpanPolyfillExtensions.cs 30% <0%> (ø)
src/Nerdbank.Streams/MultiplexingStream.cs 91.19% <0%> (+0.95%) ⬆️
src/Nerdbank.Streams/BufferTextWriter.cs 88.04% <0%> (+1.08%) ⬆️
src/Nerdbank.Streams/Utilities.cs 97.26% <0%> (+1.36%) ⬆️
src/Nerdbank.Streams/MultiplexingStream.Channel.cs 92.43% <0%> (+10.08%) ⬆️
src/Nerdbank.Streams/PipeExtensions.cs 99.1% <0%> (+16.14%) ⬆️
src/IsolatedTestHost/TestOutputHelper.cs 50% <0%> (+50%) ⬆️
src/IsolatedTestHost/Program.cs 59.42% <0%> (+59.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ee578f...9073cc0. Read the comment docs.

@AArnott AArnott merged commit 827b1f1 into master Dec 9, 2019
@AArnott AArnott deleted the fix131 branch December 9, 2019 18:54
AArnott added a commit that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DidFlush event to MonitoringStream
1 participant