Update package dependencies #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required accomodating some newly obsoleted APIs in PipeReader/PipeWriter. There were some behavior changes as well where PipeWriter.Advance() no longer throws where it used to. We also now call CompleteAsync() instead of Complete() when we are in async contexts.
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 88.12% 90.28% +2.15%
==========================================
Files 33 34 +1
Lines 2358 2429 +71
==========================================
+ Hits 2078 2193 +115
+ Misses 280 236 -44
Continue to review full report at Codecov.
|
This gets us to a version that can compile with the .NET Native tool chain.
Update vs-threading dependency
2.1 is LTS and 3.1 is LTS. Everything else is moot.
This fixes a bug where the last Channel transmission can be truncated.
AArnott
force-pushed
the
updateDependencies
branch
from
19a1ff0 to
3e2105f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required accomodating some newly obsoleted APIs in PipeReader/PipeWriter.
There were some behavior changes as well where PipeWriter.Advance() no longer throws where it used to.
We also now call CompleteAsync() instead of Complete() when we are in async contexts.
This also adds a test run on netcoreapp3.1.