Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE thrown from OnChannelTerminatedAsync #125

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Fix NRE thrown from OnChannelTerminatedAsync #125

merged 2 commits into from
Sep 26, 2019

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Sep 26, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #125 into master will decrease coverage by 2.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #125      +/-   ##
=========================================
- Coverage   88.88%   86.7%   -2.18%     
=========================================
  Files          33      33              
  Lines        2340    2340              
  Branches      436     435       -1     
=========================================
- Hits         2080    2029      -51     
- Misses        224     274      +50     
- Partials       36      37       +1
Impacted Files Coverage Δ
src/Nerdbank.Streams/MultiplexingStream.cs 89.76% <100%> (+0.95%) ⬆️
src/Nerdbank.Streams/PipeExtensions.cs 84.09% <0%> (-15.91%) ⬇️
src/Nerdbank.Streams/MultiplexingStream.Channel.cs 78.76% <0%> (-8.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c0cf9...2800513. Read the comment docs.

@AArnott AArnott merged commit cd61adc into master Sep 26, 2019
@AArnott AArnott deleted the fixNRE branch September 26, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant