Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please discuss how HasConversion interacts with the change tracker #2196

Closed
togakangaroo opened this issue Mar 19, 2020 · 2 comments
Closed

Comments

@togakangaroo
Copy link

Does the change tracker consider the value before or after conversion? In other words, if I have a JObject property and a conversion serializing it to a string, can I change its contents and have it save because the serialized value would be different than the loaded value?

@AndriySvyryd
Copy link
Member

Change tracker uses value comparers for this, see #1986 and #2192

@ajcvickers
Copy link
Contributor

@togakangaroo To add to what Andriy said, we compare without converting mostly because the other way would require many conversions just to detect changes, which would be very slow.

#2192 is documenting exactly your case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants