engine factory is now supposed to create an engine which is ready to run (hence the method name change), #736

adamsitnik · adamsitnik · commit 773c47f4ec94 · 2018-05-22T19:51:21.000+02:00
diff --git a/tests/BenchmarkDotNet.IntegrationTests/CustomEngineTests.cs b/tests/BenchmarkDotNet.IntegrationTests/CustomEngineTests.cs
@@ -54,12 +54,18 @@ public void Empty() { }
 
         public class CustomFactory : IEngineFactory
         {
-            public IEngine CreateReadyToRun(EngineParameters engineParameters) 
-                => new CustomEngine
+            public IEngine CreateReadyToRun(EngineParameters engineParameters)
+            {
+                var engine = new CustomEngine
                 {
                     GlobalCleanupAction = engineParameters.GlobalCleanupAction,
                     GlobalSetupAction = engineParameters.GlobalSetupAction
                 };
+                
+                engine.GlobalSetupAction?.Invoke(); // engine factory is now supposed to create an engine which is ready to run (hence the method name change) 
+
+                return engine;
+            }
         }
 
         public class CustomEngine : IEngine

Original file line number	Diff line number	Diff line change
`@@ -54,12 +54,18 @@ public void Empty() { }`
`54`	`54`
`55`	`55`	`public class CustomFactory : IEngineFactory`
`56`	`56`	`{`
`57`		`- public IEngine CreateReadyToRun(EngineParameters engineParameters)`
`58`		`- => new CustomEngine`
	`57`	`+ public IEngine CreateReadyToRun(EngineParameters engineParameters)`
	`58`	`+ {`
	`59`	`+ var engine = new CustomEngine`
`59`	`60`	`{`
`60`	`61`	`GlobalCleanupAction = engineParameters.GlobalCleanupAction,`
`61`	`62`	`GlobalSetupAction = engineParameters.GlobalSetupAction`
`62`	`63`	`};`
	`64`	`+`
	`65`	`+ engine.GlobalSetupAction?.Invoke(); // engine factory is now supposed to create an engine which is ready to run (hence the method name change)`
	`66`	`+`
	`67`	`+ return engine;`
	`68`	`+ }`
`63`	`69`	`}`
`64`	`70`
`65`	`71`	`public class CustomEngine : IEngine`