Add "docker create" support #6907
Conversation
This exposes the already existing "create container" operation. It is very similar to "docker run -d" except it doesn't actually start the container, but just prepares it. It can then be manually started using "docker start" at any point. Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson) Conflicts: api/client/commands.go runconfig/parse.go
Docker-DCO-1.1-Signed-off-by: Alexander Larsson <alexl@redhat.com> (github: alexlarsson)
| -a, --attach=[] Attach to stdin, stdout or stderr. | ||
| -c, --cpu-shares=0 CPU shares (relative weight) | ||
| --cidfile="" Write the container ID to the file | ||
| --dns=[] Set custom dns servers |
|
@jamtur01 The documentation for this command is mostly a copy of existing docs for docker run. So, the comments that you have added apply to docker run as well. Do you think it makes sense to fix the docs for both in a separate commit? |
|
Pinging those who were looking at the original PR #4548 -- @shykes @crosbymichael @vieux @unclejack @tiborvass to please take a look. |
|
I don't mind. |
|
LGTM |
|
Thanks @tiborvass That's 2 LGTMs counting @unclejack LGTM on the original PR :) |
|
@mrunalp I would like @vieux and/or @crosbymichael to review this one before merging. |
|
The LGTM I posted on the original PR was for @shykes' branch. |
|
LGTM - though if you create the |
|
@vieux @crosbymichael ping, review please. |
|
@shykes : not much to discuss, I'm ok to merge, just wanted an extra pair of eyes on it for regressions (from https://botbot.me/freenode/docker-dev/msg/18199474/ ) |
|
mrunalp: @tiborvass would you mind taking 6907 and carrying it to merge? - yes (from irc again) |
|
Another use case for this is to create volume containers using the |
|
@mrunalp Could you rebase this PR, please? |
|
@unclejack Isn't @tiborvass carrying this one on at #7110? If not, I will be glad to rebase it. |
|
@mrunalp That's right. I forgot about that PR, sorry. |
This PR is for the remaining two commits for docker create. (#4548)
This exposes the already existing "create container" operation. It is
very similar to "docker run -d" except it doesn't actually start the
container, but just prepares it. It can then be manually started using
"docker start" at any point.
Docker-DCO-1.1-Signed-off-by: Alexander Larsson alexl@redhat.com (github: alexlarsson)