Skip to content

Commit 93aaa1b

Browse files
committed
Remove pdo_sqlsrv from known vendor issues list
1 parent ce45348 commit 93aaa1b

File tree

3 files changed

+0
-17
lines changed

3 files changed

+0
-17
lines changed

docs/en/reference/configuration.rst

-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ interfaces to use. It can be configured in one of three ways:
139139
extension.
140140
**Note that this driver caused problems in our tests. Prefer the oci8 driver if possible.**
141141
- ``pdo_sqlsrv``: A Microsoft SQL Server driver that uses pdo\_sqlsrv PDO
142-
**Note that this driver caused problems in our tests. Prefer the sqlsrv driver if possible.**
143142
- ``sqlsrv``: A Microsoft SQL Server driver that uses the sqlsrv PHP extension.
144143
- ``oci8``: An Oracle driver that uses the oci8 PHP extension.
145144
- ``sqlanywhere``: A SAP Sybase SQL Anywhere driver that uses the sqlanywhere PHP extension.

docs/en/reference/known-vendor-issues.rst

-11
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,3 @@ liberal DateTime parser that detects the format automatically:
179179
Type::overrideType('datetime_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
180180
Type::overrideType('datetimetz_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
181181
Type::overrideType('time_immutable', 'Doctrine\DBAL\Types\VarDateTimeImmutableType');
182-
183-
PDO_SQLSRV: VARBINARY/BLOB columns
184-
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
185-
186-
The ``PDO_SQLSRV`` driver currently has a bug when binding values to
187-
VARBINARY/BLOB columns with ``bindValue`` in prepared statements.
188-
This raises an implicit conversion from data type error as it tries
189-
to convert a character type value to a binary type value even if
190-
you explicitly define the value as ``ParameterType::LARGE_OBJECT`` type.
191-
Therefore it is highly encouraged to use the native ``sqlsrv``
192-
driver instead which does not have this limitation.

tests/Doctrine/Tests/DBAL/Functional/BlobTest.php

-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace Doctrine\Tests\DBAL\Functional;
44

55
use Doctrine\DBAL\Driver\OCI8\Driver as OCI8Driver;
6-
use Doctrine\DBAL\Driver\PDOSqlsrv\Driver as PDOSQLSrvDriver;
76
use Doctrine\DBAL\FetchMode;
87
use Doctrine\DBAL\ParameterType;
98
use Doctrine\DBAL\Schema\AbstractSchemaManager;
@@ -23,10 +22,6 @@ protected function setUp()
2322
{
2423
parent::setUp();
2524

26-
if ($this->connection->getDriver() instanceof PDOSQLSrvDriver) {
27-
$this->markTestSkipped('This test does not work on pdo_sqlsrv driver due to a bug. See: http://social.msdn.microsoft.com/Forums/sqlserver/en-US/5a755bdd-41e9-45cb-9166-c9da4475bb94/how-to-set-null-for-varbinarymax-using-bindvalue-using-pdosqlsrv?forum=sqldriverforphp');
28-
}
29-
3025
/** @var AbstractSchemaManager $sm */
3126
$table = new Table('blob_table');
3227
$table->addColumn('id', 'integer');

0 commit comments

Comments
 (0)