Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding logs for ipam state #2147

Merged
merged 1 commit into from
May 15, 2018
Merged

Adding logs for ipam state #2147

merged 1 commit into from
May 15, 2018

Conversation

abhi
Copy link
Contributor

@abhi abhi commented May 10, 2018

Signed-off-by: Abhinandan Prativadi abhi@docker.com

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d5818e7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2147   +/-   ##
=========================================
  Coverage          ?   40.54%           
=========================================
  Files             ?      139           
  Lines             ?    22496           
  Branches          ?        0           
=========================================
  Hits              ?     9121           
  Misses            ?    12031           
  Partials          ?     1344
Impacted Files Coverage Δ
bitseq/sequence.go 83.29% <100%> (ø)
ipam/allocator.go 71.88% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5818e7...133edb8. Read the comment docs.

@@ -537,6 +538,7 @@ func (a *Allocator) getAddress(nw *net.IPNet, bitmask *bitseq.Handle, prefAddres
base *net.IPNet
)

logrus.Debugf("Received request for address PoolID:%v %s Serial:%v PrefAddress:%v ", nw, bitmask.String(), serial, prefAddress)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
Copy link

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants