feat: wrap apps with theme, include extensions and add docs for the hook #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langz
approved these changes
Sep 27, 2023
tujoworker
force-pushed
the
feat/wrap-provider
branch
14 times, most recently
from
636ac7c to
0508731
Compare
Update README.md Co-authored-by: Anders <anderslangseth@gmail.com>
tujoworker
force-pushed
the
feat/wrap-provider
branch
from
0508731 to
4a1f8f9
Compare
|
It took some time to get the CI up and running again. Not sure why it did not work anymore. But it works now that we call the playwright install within the workspace, where we run the test:
|
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
langz
reviewed
Sep 28, 2023
| @@ -1,4 +1,5 @@ | |||
| import React from 'react' | |||
| import { Theme } from '@dnb/eufemia/shared' | |||
There was a problem hiding this comment.
Seem like this import causes the following issue:
ERROR #98124 WEBPACK.DEVELOP-HTML
Generating development SSR bundle failed
Can't resolve '@dnb/eufemia/shared' in '/Users/anderslangseth/dev/eufemia/node_modules/gatsby-plugin-eufemia-theme-handler'
If you're trying to use a package make sure that '@dnb/eufemia/shared' is installed. If you're trying to use a local file make sure that the path is correct.
File: ../../node_modules/gatsby-plugin-eufemia-theme-handler/themeHandler.js:2:0
Also reported here: https://github.com/dnbexperience/eufemia/pull/2671/files#r1339666868
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.