Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make set theme callback param optional #17

Merged
merged 3 commits into from
Oct 11, 2023
Merged

fix: make set theme callback param optional #17

merged 3 commits into from
Oct 11, 2023

Conversation

ahmetacer5
Copy link
Contributor

Description

Fix/make set theme callback param optional

Current status

When we want to call the setTheme without the callback the typecheck complains, but in fact callback treated as optional in useTheme function.
image

Change

This change adds correct type to callback param.

@tujoworker tujoworker force-pushed the main branch 2 times, most recently from fc77415 to da3368e Compare October 11, 2023 11:39
tujoworker
tujoworker approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👌

@tujoworker tujoworker changed the title Fix/make set theme callback param optional fix: make set theme callback param optional Oct 11, 2023
@tujoworker tujoworker merged commit e62ae54 into dnbexperience:main Oct 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmetacer5 @tujoworker