Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to dagman creator #8907

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

belforte
Copy link
Member

No description provided.

@belforte belforte requested a review from sinonkt January 30, 2025 22:32
@belforte
Copy link
Member Author

@sinonkt please help me a bit by cross-checking that this only changes comments so I can merge w/o worries

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 4 comments to review
  • Pycodestyle check: succeeded
    • 75 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2362/artifact/artifacts/PullRequestReport.html

@belforte belforte force-pushed the add-comments-to-DagmanCreator branch from 6082c7a to bb613d6 Compare January 31, 2025 09:22
@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
    • 4 comments to review
  • Pycodestyle check: succeeded
    • 75 comments to review

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2363/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member Author

belforte commented Feb 4, 2025

@sinonkt please do not forget this

Copy link
Contributor

@sinonkt sinonkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'm truly apologized for late review.

@belforte
Copy link
Member Author

belforte commented Feb 4, 2025

thanks Krittin !

@belforte belforte merged commit d9bea5a into dmwm:master Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants