-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bumping WMCore version script. #8891
Conversation
Jenkins results:
|
Let's put this in the |
Jenkins results:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good ! But as indicated in the comment, have pity of those with primitive bash skills who may still want/need-to understdand
fi | ||
|
||
if [[ "$PWD" =~ CRABServer ]]; then | ||
[[ $PWD =~ (.*)/CRABServer.* ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is quite a "bash masterpiece", took me a while to understand what it does. Please add some comment describing what it does, to help future maintainers. Something along the line of ... make sure pwd is part of the CRABServer repository tree and set wdir to point to the top dir of the repo, i.e. a description in English of what you want to achieve, not how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acknowledge, Stefano!
Jenkins results:
|
Resolve #8880 |
Note that this is just the draft script that bumping wmcore version on both CRABServer and TaskWorker.
Once reviewed the bumping will be made before merged pull request. #8880