Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bumping WMCore version script. #8891

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Conversation

sinonkt
Copy link
Contributor

@sinonkt sinonkt commented Jan 23, 2025

Note that this is just the draft script that bumping wmcore version on both CRABServer and TaskWorker.
Once reviewed the bumping will be made before merged pull request. #8880

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2335/artifact/artifacts/PullRequestReport.html

@belforte
Copy link
Member

Let's put this in the cicd directory. For some historical reasons CRABServer/scripts contains scripts to be executed by remote jobs and some odd things in scripts/Monitor and scripts/Utils which need to be removed as obsolete or moved elsewhere.

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2339/artifact/artifacts/PullRequestReport.html

Copy link
Member

@belforte belforte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ! But as indicated in the comment, have pity of those with primitive bash skills who may still want/need-to understdand

fi

if [[ "$PWD" =~ CRABServer ]]; then
[[ $PWD =~ (.*)/CRABServer.* ]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is quite a "bash masterpiece", took me a while to understand what it does. Please add some comment describing what it does, to help future maintainers. Something along the line of ... make sure pwd is part of the CRABServer repository tree and set wdir to point to the top dir of the repo, i.e. a description in English of what you want to achieve, not how.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledge, Stefano!

@cmsdmwmbot
Copy link

Jenkins results:

  • Python3 Pylint check: succeeded
  • Pycodestyle check: succeeded

Details at https://cmssdt.cern.ch/dmwm-jenkins/view/All/job/DMWM-CRABServer-PR-test/2340/artifact/artifacts/PullRequestReport.html

@sinonkt sinonkt merged commit c54b1bd into master Jan 27, 2025
2 checks passed
@sinonkt
Copy link
Contributor Author

sinonkt commented Jan 27, 2025

Resolve #8880

@sinonkt sinonkt deleted the wmcore_bump_version_script branch January 27, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants